Skip to content

Add missing import in freebsd nocgo stub#52

Merged
fuweid merged 1 commit into
containerd:masterfrom
zhsj:fix-import
Apr 9, 2021
Merged

Add missing import in freebsd nocgo stub#52
fuweid merged 1 commit into
containerd:masterfrom
zhsj:fix-import

Conversation

@zhsj

@zhsj zhsj commented Apr 8, 2021

Copy link
Copy Markdown
Contributor
$ GOOS=freebsd CGO_ENABLED=0 go build .
# github.com/containerd/console
./pty_freebsd_nocgo.go:30:17: undefined: os

Signed-off-by: Shengjing Zhu <zhsj@debian.org>

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

thaJeztah commented Apr 8, 2021

Copy link
Copy Markdown
Member

looks like it was introduced in #50

Should we add a cross target in github actions to catch these?

@thaJeztah

Copy link
Copy Markdown
Member

@samuelkarp @crosbymichael ptal

@samuelkarp samuelkarp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fuweid fuweid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
fuweid merged commit 2f1e3d2 into containerd:master Apr 9, 2021
@zhsj
zhsj deleted the fix-import branch April 9, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants