Describe new platform:... sections - #31
Merged
Merged
Conversation
vrutkovs
approved these changes
Jul 28, 2017
lcarva
approved these changes
Jul 28, 2017
| Platform description | ||
| ~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| When a section name begins "platform:" it is interpreted not as an |
|
|
||
| architecture (optional) | ||
| the GOARCH for the platform -- the platform name is assumed to be | ||
| the same as the GOARCH is this is not specified |
| is required for. If no platform is specified, no node selector will be | ||
| used. | ||
|
|
||
| Platform description |
Contributor
There was a problem hiding this comment.
Instead of using a prefix to identify platform specific configurations, what if we introduced a new configuration file? osbs_platforms.yaml ?
Not sure if this makes the system more complicated overall. Just mentioning it now because we are unlikely to change it later on.
Member
Author
There was a problem hiding this comment.
Ideally, the osbs configuration file would already be YAML and we'd add a new key alongside 'instances'.
I think it makes sense to have a single configuration file for this. After all, platform names are used elsewhere in this configuration file, so it's useful to have a nearby reference for what each platform is.
twaugh
force-pushed
the
platform-description
branch
from
July 28, 2017 12:53
ea7c585 to
d013100
Compare
These sections perform two functions: * set the GOARCH architecture name for each platform, if different from the platform name * allow publishing v1 images on a per-platform basis Signed-off-by: Tim Waugh <twaugh@redhat.com>
twaugh
force-pushed
the
platform-description
branch
from
July 28, 2017 12:58
d013100 to
6ee078b
Compare
Member
Author
|
Updated, along with the new condition that only one platform is allowed to enable v1. |
lcarva
approved these changes
Jul 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These sections perform two functions:
set the GOARCH architecture name for each platform, if different from
the platform name
allow publishing v1 images on a per-platform basis
Signed-off-by: Tim Waugh twaugh@redhat.com