Refactor Keys and Values iterators to only have one type parameter. - #4
Refactor Keys and Values iterators to only have one type parameter.#4reem wants to merge 1 commit into
Conversation
reem
commented
Nov 23, 2015
|
Is there a way to reduce the duplication of the Edit: It seems like we can just replace those structs with a single |
|
I'm not sure it's advisable to make the source of this deviate this substantially from std. I was under the impression that this was largely intended to just add missing APIs. |
|
Yeah, this has just bugged me for a while and I don't think it's possible to fix in std (it would be a breaking change). |
|
Just philosophizing, but having both the K and V parameters means that the internal memory layout has greater freedom to change, so in that sense dropping them is limiting future internal refactoring. |
|
@bluss this is true. I originally figured I would need to erase the key/value type by storing its size, I only later discovered it's unnecessary right now. |