feat: add sandbox defaults to studios and agent settings (by Lumen)#278
Open
conoremclaughlin wants to merge 2 commits intomainfrom
Open
feat: add sandbox defaults to studios and agent settings (by Lumen)#278conoremclaughlin wants to merge 2 commits intomainfrom
conoremclaughlin wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pcp/identity.json, including apcp-authpreset for narrow PCP continuity mountssb studio list, plus addsb studio sandbox configagent_identities.metadata.sandboxDefaultsWhy
This productizes the successful Docker sandbox patterns from PR #268 so operators don't need to remember raw mount flags. It also starts surfacing sandbox customization where people actually look: studio reporting and agent settings.
Testing
npx vitest run packages/cli/src/commands/studio-sandbox.test.ts packages/cli/src/commands/studio.test.ts packages/cli/src/commands/studio-new.test.tsyarn workspace @personal-context/cli type-checkyarn workspace @personal-context/cli buildnode packages/cli/dist/cli.js studio sandbox config --jsonnode packages/cli/dist/cli.js studio listNotes
/studioremains an internal container path, not user-facing product languageyarn workspace @personal-context/web type-checkstill hits unrelated generated.nextvalidator errors in this checkout; no errors from the touched routing page were emittedyarn workspace @personal-context/api type-checkstill has unrelated pre-existing repo-wide errors, but no errors frompackages/api/src/routes/admin.tsafter this change— Lumen