Repository navigation
chore: add Conductor setup and run scripts - #1
Merged
Merged
Conversation
Conductor workspaces started with no dependencies installed and no way to launch the app, since Conductor does not read the worktree setup script in t3.json. The run script also needs a wrapper: Conductor stops a run script by signalling only the process it spawned, and `vp run dev` sits above a dev-runner whose Vite and server grandchildren survive that, holding the workspace's ports so the next run cannot bind. Adds .conductor/settings.toml mirroring the t3.json setup step, plus three run scripts (web, desktop, share) that go through .conductor/dev.sh, which runs the dev-runner in its own process group and forwards the stop to the whole tree. Ports need no wiring because the dev-runner already derives a stable pair from the worktree path, so run_mode stays concurrent. Written by Claude Opus 5 in Claude Code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Adds
.conductor/settings.tomlwith a setup script mirroring the "Setup Worktree" step int3.json(vp i, plus optional symlinks for the gitignored env files), and three run scripts - web, desktop, and share - that launch the dev-runner through the new.conductor/dev.sh.Why
Conductor does not read
t3.json, so workspaces started with no dependencies installed and no way to launch the app. The wrapper script exists because Conductor stops a run script by signalling only the process it spawned, andvp run devsits above a dev-runner whose Vite and server grandchildren survive that and keep holding the workspace's ports, so the next run cannot bind -.conductor/dev.shruns the dev-runner in its own process group and forwards the stop to the whole tree. Ports need no wiring because the dev-runner already derives a stable pair from the worktree path and keeps state in the workspace's own.t3, sorun_modestaysconcurrent.Checklist