Skip to content

conformance: remove the local debug proxy scaffolding - #256

Merged
iainmcgin merged 1 commit into
mainfrom
chore/remove-conformance-debug-proxies
Aug 21, 2026
Merged

iainmcgin merged 1 commit into
mainfrom
chore/remove-conformance-debug-proxies

Conversation

@iainmcgin

Copy link
Copy Markdown
Collaborator

Fixes #248

Removes the local debugging scaffolding from the conformance server: start_caddy_proxy, start_tcplog_proxy, and the ENABLE_CADDY_PROXY / ENABLE_TCPLOG dispatch in main. Net 114 lines deleted.

Both helpers spawned binaries that are not part of this repository, are not built by the Taskfile, and are documented nowhere — tcplog defaulted to /tmp/tcplog/target/release/tcplog, a cargo target directory that exists on one machine. Grepping the tree for tcplog, caddy, TCPLOG_BIN, CADDY_BIN, ENABLE_TCPLOG and ENABLE_CADDY_PROXY turns up nothing outside the deleted code, so nothing else in the repo, the Taskfile or CI referenced them.

They cost nothing at runtime, since both were off unless the environment variable was set. The cost was that a contributor reading the conformance harness met a hundred lines of dead-end setup pointing at paths they do not have.

main now reports the real listener port unconditionally. The _proxy_child half of the old tuple was None on every path the deleted branches did not take, so dropping the binding changes nothing about what is kept alive. std::process::Command and Stdio became unused and are removed.

No changelog fragment. conformance is publish = false and has no surface a library user consumes, and the repo's own practice matches: of the 33 commits touching only harness, CI, docs, examples or benches — including all four since changie was adopted in #195 — none carries a fragment.

Verified beyond the build: feeding a ServerCompatRequest on stdin, the server logs its listener address and writes a ServerCompatResponse whose port field decodes to that same port, and a live Connect JSON unary call against it returns a well-formed ConformancePayload. Serving is intact end to end.

One note on CI: two handler::tests element-budget tests fail on main right now, independently of this change — fixture rot from buffa 0.9.1, fixed by #239. This diff touches one file under conformance/ and does not link that crate's test binary.

`start_caddy_proxy` and `start_tcplog_proxy` spawned binaries that are not
part of this repository, are not built by the Taskfile, and are documented
nowhere. `tcplog` defaulted to /tmp/tcplog/target/release/tcplog, a cargo
target directory that exists on one machine.

Both were env-gated and off by default, so they cost nothing at runtime.
The cost was that a contributor reading the conformance harness met a
hundred lines of dead-end setup pointing at paths they do not have.

`main` now reports the real listener port unconditionally. The proxy child
handle it used to hold was `None` on every path the deleted branches did
not take, so nothing that was being kept alive is dropped any earlier.

No-Verification-Needed: test-harness-only deletion in a publish=false crate
Signed-off-by: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
@iainmcgin
iainmcgin force-pushed the chore/remove-conformance-debug-proxies branch from e80f05c to 602404b Compare July 24, 2026 23:23
@iainmcgin
iainmcgin marked this pull request as ready for review August 1, 2026 21:17
@iainmcgin
iainmcgin added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit a2f3b72 Aug 21, 2026
14 checks passed
@iainmcgin
iainmcgin deleted the chore/remove-conformance-debug-proxies branch August 21, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conformance: remove the undocumented local debug proxy scaffolding

2 participants