conformance: remove the local debug proxy scaffolding - #256
Merged
Merged
Conversation
`start_caddy_proxy` and `start_tcplog_proxy` spawned binaries that are not part of this repository, are not built by the Taskfile, and are documented nowhere. `tcplog` defaulted to /tmp/tcplog/target/release/tcplog, a cargo target directory that exists on one machine. Both were env-gated and off by default, so they cost nothing at runtime. The cost was that a contributor reading the conformance harness met a hundred lines of dead-end setup pointing at paths they do not have. `main` now reports the real listener port unconditionally. The proxy child handle it used to hold was `None` on every path the deleted branches did not take, so nothing that was being kept alive is dropped any earlier. No-Verification-Needed: test-harness-only deletion in a publish=false crate Signed-off-by: Iain McGinniss <309153+iainmcgin@users.noreply.github.com>
iainmcgin
force-pushed
the
chore/remove-conformance-debug-proxies
branch
from
July 24, 2026 23:23
e80f05c to
602404b
Compare
iainmcgin
marked this pull request as ready for review
August 1, 2026 21:17
asacamano
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
Removes the local debugging scaffolding from the conformance server:
start_caddy_proxy,start_tcplog_proxy, and theENABLE_CADDY_PROXY/ENABLE_TCPLOGdispatch inmain. Net 114 lines deleted.Both helpers spawned binaries that are not part of this repository, are not built by the Taskfile, and are documented nowhere —
tcplogdefaulted to/tmp/tcplog/target/release/tcplog, a cargo target directory that exists on one machine. Grepping the tree fortcplog,caddy,TCPLOG_BIN,CADDY_BIN,ENABLE_TCPLOGandENABLE_CADDY_PROXYturns up nothing outside the deleted code, so nothing else in the repo, the Taskfile or CI referenced them.They cost nothing at runtime, since both were off unless the environment variable was set. The cost was that a contributor reading the conformance harness met a hundred lines of dead-end setup pointing at paths they do not have.
mainnow reports the real listener port unconditionally. The_proxy_childhalf of the old tuple wasNoneon every path the deleted branches did not take, so dropping the binding changes nothing about what is kept alive.std::process::CommandandStdiobecame unused and are removed.No changelog fragment.
conformanceispublish = falseand has no surface a library user consumes, and the repo's own practice matches: of the 33 commits touching only harness, CI, docs, examples or benches — including all four since changie was adopted in #195 — none carries a fragment.Verified beyond the build: feeding a
ServerCompatRequeston stdin, the server logs its listener address and writes aServerCompatResponsewhose port field decodes to that same port, and a live Connect JSON unary call against it returns a well-formedConformancePayload. Serving is intact end to end.One note on CI: two
handler::testselement-budget tests fail onmainright now, independently of this change — fixture rot from buffa 0.9.1, fixed by #239. This diff touches one file underconformance/and does not link that crate's test binary.