Repository navigation
Improvements/DI module - #398
Merged
Antony Stubbs (astubbs) merged 7 commits intoSep 2, 2022
Merged
Conversation
6 tasks done
Antony Stubbs (astubbs)
marked this pull request as ready for review
August 25, 2022 09:51
1 task
Antony Stubbs (astubbs)
left a comment
Antony Stubbs (astubbs)
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM
Roman Kolesnev (rkolesnev)
approved these changes
Sep 2, 2022
Roman Kolesnev (rkolesnev)
left a comment
Roman Kolesnev (rkolesnev)
left a comment
Contributor
There was a problem hiding this comment.
LGTM - couple of questions - added as comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency injection, needed for sane testing of transactions.
Abiding by the zero dependencies policy - just needed something simple.