Repository navigation
Fix service discovery bug in kubernetes-extensions (#19139) - #468
Closed
Parth Agrawal (pagrawal10) wants to merge 1 commit into
Closed
Parth Agrawal (pagrawal10) wants to merge 1 commit into
Parth Agrawal (pagrawal10) wants to merge 1 commit into
Conversation
Backport of apache#19139. Use Kubernetes container readiness (in addition to labels/annotations) to decide whether a pod is available for service discovery. Pods whose containers are not ready (e.g. OOM-killed but still carrying announcement labels) are now removed from discovery caches and re-added once ready again. - DefaultK8sApiClient: filter not-ready pods on list; remap watch events (MODIFIED->ADDED when ready, MODIFIED->NOT_READY when unready, skip not-ready ADDED events). - WatchResult: add MODIFIED and synthetic NOT_READY event types. - BaseNodeRoleWatcher: add childRemoved(node, skipIfUnknown) overload to silently ignore removals of nodes not in the cache. - K8sDruidNodeDiscoveryProvider: treat NOT_READY like DELETED, using skipIfUnknown=true for all k8s discovery removals. - Docs/spelling updates for readiness probe guidance. Adapted for the 30.0.1 branch: new unit test converted from JUnit 5 to JUnit 4 to match the module, and JUnit annotations adjusted accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of apache#19139.
Use Kubernetes container readiness (in addition to labels/annotations) to decide whether a pod is available for service discovery. Pods whose containers are not ready (e.g. OOM-killed but still carrying announcement labels) are now removed from discovery caches and re-added once ready again.
Adapted for the 30.0.1 branch: new unit test converted from JUnit 5 to JUnit 4 to match the module, and JUnit annotations adjusted accordingly.
Fixes #XXXX.
Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
For tips about how to write a good release note, see Release notes.
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: