Skip to content

Update to scikit-build 0.8.0#14

Merged
jcfr merged 8 commits intoconda-forge:masterfrom
jcfr:update-to-scikit-build-0.8.0
Aug 22, 2018
Merged

Update to scikit-build 0.8.0#14
jcfr merged 8 commits intoconda-forge:masterfrom
jcfr:update-to-scikit-build-0.8.0

Conversation

@jcfr
Copy link
Copy Markdown
Contributor

@jcfr jcfr commented Aug 21, 2018

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@jcfr jcfr force-pushed the update-to-scikit-build-0.8.0 branch from dd5deea to 2e7ec38 Compare August 21, 2018 18:22
@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jcfr
Copy link
Copy Markdown
Contributor Author

jcfr commented Aug 21, 2018

@moorepants Thanks for the help earlier today, after Appveyor completes, we should have a new release of scikit-build available on conda-forge.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [44, 45]

@jcfr jcfr force-pushed the update-to-scikit-build-0.8.0 branch from c4f6eca to 0d4daa9 Compare August 22, 2018 05:14
@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jcfr jcfr merged commit 7f4ba6d into conda-forge:master Aug 22, 2018
@jcfr jcfr deleted the update-to-scikit-build-0.8.0 branch August 22, 2018 05:59
@moorepants
Copy link
Copy Markdown
Contributor

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants