Skip to content

pgcli v3.1.0#21

Merged
github-actions[bot] merged 7 commits into
conda-forge:masterfrom
regro-cf-autotick-bot:3.1.0_h0a1fc6
Dec 15, 2020
Merged

pgcli v3.1.0#21
github-actions[bot] merged 7 commits into
conda-forge:masterfrom
regro-cf-autotick-bot:3.1.0_h0a1fc6

Conversation

@regro-cf-autotick-bot

Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/416592904, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • pendulum
  • ipython-sql

Packages found in the meta.yaml but not found by inspection:

  • humanize
  • tabulate

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dhirschfeld

Copy link
Copy Markdown
Member
install_requirements = [
    "pgspecial>=1.11.8",
    "click >= 4.1",
    "Pygments >= 2.0",  # Pygments has to be Capitalcased. WTF?
    # We still need to use pt-2 unless pt-3 released on Fedora32
    # see: https://github.com/dbcli/pgcli/pull/1197
    "prompt_toolkit>=2.0.6,<4.0.0",
    "psycopg2 >= 2.8",
    "sqlparse >=0.3.0,<0.5",
    "configobj >= 5.0.6",
    "pendulum>=2.1.0",
    "cli_helpers[styles] >= 2.0.0",
]

https://github.com/dbcli/pgcli/blob/baea7690b0e64cf2487a5ebcc61ca2e6736caf05/setup.py#L8-L20

@dhirschfeld

Copy link
Copy Markdown
Member

@dhirschfeld

Copy link
Copy Markdown
Member

AFAICT we also don't need tabulate - dbcli/pgcli#735

@dhirschfeld dhirschfeld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's good to go now...

@dhirschfeld

Copy link
Copy Markdown
Member

tabulate isn't a direct dependency but is a dependency of cli_helpers. Unfortunately it's not specified in cli_helpers so I'll add it back here until the cli_helpers pacakage is fixed.

* It's not yet included in `cli_helpers` where it is required.
  conda-forge/cli_helpers-feedstock#9
@dhirschfeld dhirschfeld added the automerge Merge the PR when CI passes label Dec 15, 2020
@github-actions github-actions Bot merged commit c0516a2 into conda-forge:master Dec 15, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 3.1.0_h0a1fc6 branch December 15, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants