Ingest run_constraints on other llvm packages from repodata patches#142
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This comment was marked as outdated.
This comment was marked as outdated.
| - {{ pin_subpackage("llvm-tools", exact=True) }} | ||
| - libcxx >={{ cxx_compiler_version }}.a0 # [osx] | ||
| run_constrained: | ||
| - llvm {{ version }} | ||
| - llvm-tools {{ version }} | ||
| - clang {{ version }} | ||
| - clang-tools {{ version }} |
There was a problem hiding this comment.
Adding llvm-tools as a run-constraint when it's already pinned as a subpackage seems... unnecessary?
| run_constrained: # [not win] | ||
| - llvmdev {{ version }} # [not win] |
There was a problem hiding this comment.
This part I don't understand either. The run-constraint from llvm on llvmdev should have been there already, but it still shows up in the diff of #141.
beckermr
requested review from
JohanMabille,
SylvainCorlay,
inducer,
isuruf,
jakirkham,
mingwandroid,
timsnyder and
xhochy
as code owners
|
I'll need to resolve the merge conflicts at the cli. Will do later. |
h-vetinari
force-pushed
the
constraints
branch
from
9217917 to
cd8cb5b
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
3 participants
Closes #141 (hopefully)
Still a draft because I'm not sure about some things (will comment in the diff).