Skip to content

Remove redundant paragonie/random_compat dependency#44

Merged
KorvinSzanto merged 1 commit intoconcretecms:9.5.xfrom
brendt:compat/remove-paragonie-random_compat
Apr 8, 2026
Merged

Remove redundant paragonie/random_compat dependency#44
KorvinSzanto merged 1 commit intoconcretecms:9.5.xfrom
brendt:compat/remove-paragonie-random_compat

Conversation

@brendt
Copy link
Copy Markdown
Contributor

@brendt brendt commented Apr 3, 2026

This package depends on paragonie/random_compat: ^2.0, but also php: ^7.3||^8.0. Since random_bytes and random_int were added in PHP 7.0, the dependency on paragonie/random_compat seems redundant?

@KorvinSzanto
Copy link
Copy Markdown
Member

Thanks for the PR and including us in your scan!

@KorvinSzanto KorvinSzanto merged commit e89e25d into concretecms:9.5.x Apr 8, 2026
KorvinSzanto referenced this pull request in concretecms/concretecms Apr 8, 2026
@mlocati
Copy link
Copy Markdown
Contributor

mlocati commented Apr 8, 2026

Does it make sense to submit pull requests to this repository? Won't it be overwritten by the next run of the core splitter?

@KorvinSzanto
Copy link
Copy Markdown
Member

KorvinSzanto commented Apr 8, 2026

@mlocati you are absolutely correct, a few things are happening here that make this confusing:

  1. @brendt ran a automated scan of projects in packagist to see which had redundant polyfill dependencies and graciously opened pull requests to fix the redundant ones he found.
  2. We use mediawiki's composer merge plugin, so Brent's scan only sees the top level dependencies for concretecms/concretecms and sees the actual list of dependencies here in this split repo
  3. I accidentally merged this here before realizing it was against the split

All that said, I've resolved this by git aming this patch in the proper repository and the accidental merge has already been wiped away by the next core split.

@brendt brendt deleted the compat/remove-paragonie-random_compat branch April 9, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants