Worker volume retention policy#386
Merged
taylorsilva merged 4 commits intoAug 21, 2025
Merged
Conversation
443e705 to
6612deb
Compare
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
fe6aaed to
6c9e83c
Compare
Member
|
Thanks for the PR! I'm running it against our topgun test suite and then I'll merge. In the future, for these kinds of changes that are updating chart functionality, you can merge them into For now, don't worry about changing it. I'll get your PR's landing in |
Contributor
Author
|
understood, thank you! |
taylorsilva
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again 👋
This PR adds in the ability to use the persistentVolumeClaimRetentionPolicy feature of statefulsets enabled by default in kubernetes 1.32.
Ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#persistentvolumeclaim-retention
Why do we need this PR?
With the HPA autoscaling feature this is a nice quality of life to allow developers to choose how they want their PVs to be reclaimed.
Changes proposed in this pull request
persistentVolumeClaimRetentionPolicy feature for worker statefulset and supporting documentation
Contributor Checklist
README.mdyesmasteris for changes related to the current release of theconcourse/concourse:latestimage and should be good to publish immediatelydevis for changes related to the next release of Concourse (aka unpublished code onmasterin concourse/concourse)Reviewer Checklist
masterordev)