Skip to content

Worker volume retention policy#386

Merged
taylorsilva merged 4 commits into
concourse:devfrom
BrandonCate:worker-volume-retention-policy
Aug 21, 2025
Merged

Worker volume retention policy#386
taylorsilva merged 4 commits into
concourse:devfrom
BrandonCate:worker-volume-retention-policy

Conversation

@BrandonCate

Copy link
Copy Markdown
Contributor

Hello again 👋

This PR adds in the ability to use the persistentVolumeClaimRetentionPolicy feature of statefulsets enabled by default in kubernetes 1.32.
Ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#persistentvolumeclaim-retention

Why do we need this PR?

With the HPA autoscaling feature this is a nice quality of life to allow developers to choose how they want their PVs to be reclaimed.

Changes proposed in this pull request

persistentVolumeClaimRetentionPolicy feature for worker statefulset and supporting documentation

Contributor Checklist

  • Variables are documented in the README.md yes
  • Which branch are you merging into? dev
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

@BrandonCate BrandonCate force-pushed the worker-volume-retention-policy branch from 443e705 to 6612deb Compare August 12, 2025 20:02
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
Signed-off-by: brandon.cate <brandon.cate@shipt.com>
@BrandonCate BrandonCate force-pushed the worker-volume-retention-policy branch from fe6aaed to 6c9e83c Compare August 12, 2025 20:17
@taylorsilva

Copy link
Copy Markdown
Member

Thanks for the PR! I'm running it against our topgun test suite and then I'll merge.

In the future, for these kinds of changes that are updating chart functionality, you can merge them into master, not dev. dev is for when we've done something like added a new CLI flag to the concourse binary. If its a pure chart-feature, like your two PR's have been, you can merge right into master.

For now, don't worry about changing it. I'll get your PR's landing in master in the next chart release.

@BrandonCate

Copy link
Copy Markdown
Contributor Author

understood, thank you!

@taylorsilva taylorsilva merged commit 0c4ac1b into concourse:dev Aug 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants