Add read_athtab function#15
Open
spacetimecurv wants to merge 1 commit intocomputationalrelativity:masterfrom
Open
Add read_athtab function#15spacetimecurv wants to merge 1 commit intocomputationalrelativity:masterfrom
spacetimecurv wants to merge 1 commit intocomputationalrelativity:masterfrom
Conversation
jfields7
reviewed
Apr 2, 2026
Comment on lines
+1641
to
+1644
| self.Y["e"] = data["Y[e]"] | ||
| self.Y["n"] = data["Y[n]"] | ||
| self.Y["p"] = data["Y[p]"] | ||
| self.Y["He4"] = data["Y[He4]"] |
Collaborator
There was a problem hiding this comment.
This needs to be more generic because not every EOS provides these fields, and some EOSs provide other fields. For example, I have various DD2 tables that define no fields except for Q1 through Q7 and cs2, and I have an SFHo table that also defines Y[He3], Y[H2], Y[H3], Y[N], A[N], and Z[N] in addition to these fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a function to read .athtab tables. Any suggestions to improve the code?