Correct Custom Selector overflow menu icon color for Day/Night themes - #6963
Open
AdityaDarke97 wants to merge 1 commit into
Open
Correct Custom Selector overflow menu icon color for Day/Night themes#6963AdityaDarke97 wants to merge 1 commit into
AdityaDarke97 wants to merge 1 commit into
Conversation
…dd 'overflow_custom_picker_menu' in colors.xml
|
✅ Generated APK variants! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the Custom Selector overflow menu icon so it correctly adapts to Day and Night themes.
Fixes #6423
Changes made:
Renamed ic_more_vert_white_24dp.xml to ic_overflow_menu_icon.xml as per suggestion made by rohit
The renamed icon now uses color 'overflow_custom_picker_menu' which was added newly in both colors (day).xml and colors (day) night.xml
Instead of making a new attribute, I used the color variable to adapt to Day and Night theme.
Tests performed
Tested prodDebug on Android 16.
Screenshots (for UI changes only)
