Allow user to specify a function to escape the output#217
Merged
Conversation
added 3 commits
March 16, 2021 12:09
The function doesn't take a second parameter. And you can't specify this function, currently. (See next commit)
This is useful if you don't want to escape a quotation mark into `"`, for example, because a later parser will parse `&` into `&` and mess up your output. Besides, the docs claim you can do this, but you cannot currently.
This is useful if you don't want to escape a quotation mark into `"`, for example, because a later parser will parse `&` into `&` and mess up your output. Besides, the docs claim you can do this, but you cannot currently.
mmm111mmm
changed the title
Member
|
Thanks! |
taku0
added a commit
to taku0/cmark-el
that referenced
this pull request
Apr 3, 2021
(commonmark/commonmark.js#217) * Correct `esc` function description. The function doesn't take a second parameter. * HtmlRenderer: Allow user to specify a custom escape function, as the docs say you can. commonmark/commonmark.js@80f63d1 Author: newfivefour <newfivefour@users.noreply.github.com> Date: Thu Mar 18 04:05:23 2021 +0300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md says you can specify an
escfunction to customise escaping of the output.However, this isn't the case. Your
escfunction argument is roundly ignored. I've changed this in theXMLandHTMLparsers so it's now taken into account.The docs used to say the
escfunction takes two parameters, the string and whether it should be escaped, but this is not the case in the codebase, so I've changed the README.md