Adds support for introspection on the delimiter character and length#21
Closed
pcj wants to merge 3 commits intocommonmark:masterfrom
Closed
Adds support for introspection on the delimiter character and length#21pcj wants to merge 3 commits intocommonmark:masterfrom
pcj wants to merge 3 commits intocommonmark:masterfrom
Conversation
- An abstract node 'Reference' that captures the link label, title, description attributes for subclasses Link, Image, AutoLink. - AutoLink node class that allows Visitor to differentiate between inline links and <autolink> types. - Support in the InlineParserImpl to capture the association between links and link reference definitions. - static Debugging functions
inline elements emphasis (italic), strong emphasis (bold), and strikethrough nodes. New interface 'Delimited' can be implemented by other custom node classes with similar behaviour.
Contributor
Author
|
Strange fails only on java8. @robinst can you check this? I'm still on java7 and would rather not change at the moment. |
Collaborator
|
Looks like the branch also includes the changes for #20. I'll just review the single commit for now. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for introspection on the delimiter character and length for
inline elements emphasis (italic), strong emphasis (bold), and
strikethrough nodes. New interface 'Delimited' can be implemented by
other custom node classes with similar behaviour.