Add type hints for cli.py#1479
Merged
Lee-W merged 3 commits intocommitizen-tools:refactorsfrom May 31, 2025
Merged
Conversation
Lee-W
reviewed
May 31, 2025
commitizen/cli.py
Outdated
| config: str | None = None | ||
| debug: bool = False | ||
| name: str | None = None | ||
| no_raise: str | None = None |
Member
There was a problem hiding this comment.
We could probably add a comment mentioning that it will later be parsed as list[int]. A bit confusing at the first glance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1479 +/- ##
==========================================
Coverage 97.82% 97.82%
==========================================
Files 57 57
Lines 2618 2619 +1
==========================================
+ Hits 2561 2562 +1
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Since the project requires Python >=3.9, argparse only raises SystemExit when non-existent commands are provided, making TypeError handling unnecessary.
Lee-W
approved these changes
May 31, 2025
This was referenced Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1477
I hope this can be merged into the
refactorsbranch instead ofmaster.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context