Support for Classic Tesla Model S - #121
Closed
zax123 wants to merge 1 commit into
Closed
Conversation
Contributor
|
@zax123 let me know if this is up to date. If yes, then it can probably be merged as is, even though the safety code will need some changes before the Tesla support can be upstreamed to openpilot. Some questions/comments:
|
|
We want and will add those safety in Panda code.
But now that we have some more people helping us, the progress is going well and we will support the code without issues. |
rbiasini
reviewed
Jul 18, 2018
| int tesla_speed = 0; | ||
| int current_car_time = -1; | ||
| int time_at_last_stalk_pull = -1; | ||
| int eac_status = 0; |
Contributor
There was a problem hiding this comment.
can you make all those shared variables starting with tesla_?
Contributor
Author
|
Hi @rbiasini, Absolutely, I will rename those shared variables. We are working on solidifying all the safety parameters on Thursday evening and will send new cleaned-up code on Friday. Thanks for looking into this! |
Contributor
|
superseded by #132 |
liruifeng1120
referenced
this pull request
in liruifeng1120/panda
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains RX and TX safety hooks for Classic (non-AP) Tesla Model S
Also contains forwarding code to bypass the EPAS kill message sent from the gateway.
Requires the harness as designed by @kalud and @zax123 and the Tesla giraffe.