Skip to content

Refactor cross-platform libc usage - #47

Merged
geohot merged 1 commit into
commaai:masterfrom
mullakhmetov:crossplatform-gettime
Jan 25, 2017
Merged

geohot merged 1 commit into
commaai:masterfrom
mullakhmetov:crossplatform-gettime

Conversation

@mullakhmetov

Copy link
Copy Markdown

Fixed TODO in common/realtime.py

Not sure exception from ctypes.CDLL call should be passed in such a way. Maybe it should raise an error? Otherwise clock_gettime will fall in runtime with AttributeError because of libc == None.

@geohot
geohot merged commit 6ab4ac2 into commaai:master Jan 25, 2017
@geohot

geohot commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

Thanks!

Although, not sure this'll work on OS X. http://stackoverflow.com/questions/5167269/clock-gettime-alternative-in-mac-os-x

@fenollp

fenollp commented Jan 25, 2017

Copy link
Copy Markdown

Not sure? How about setting up Travis CI?

@mullakhmetov

Copy link
Copy Markdown
Author

I'v tested locally (macOS 10.12.2), works fine.

SippieCup pushed a commit to SippieCup/openpilot that referenced this pull request May 1, 2019
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 10, 2019
* OpenDBC updates

* OpenDBC updates

* fix mb e350 filename

* removed question mark

* OpenDBC updates

* OpenDBC updates

* OpenDBC updates
netadvanced pushed a commit to netadvanced/openpilot that referenced this pull request Apr 2, 2020
mlocoteta pushed a commit to mlocoteta/openpilot that referenced this pull request Mar 24, 2021
* Updated the README

The original README had lots of information and it was hard to find information you were looking for.  I modified the README similar to how Comma did theirs to make navigation easier.

* Minor edits

Added a few more links and made the raw text more readable

* Final updates to README w/ questions for kegman

Questions or things that need clarification have ??? next to them
NinoFurger pushed a commit to NinoFurger/openpilot that referenced this pull request Jun 29, 2021
carleeno pushed a commit to carleeno/openpilot that referenced this pull request Aug 2, 2024
* MADS: disengage lateral on brake fix

* cleaner logic

* This makes more sense
twilsonco pushed a commit to twilsonco/openpilot that referenced this pull request Apr 17, 2025
FOREVERZAX1988 pushed a commit to FOREVERZAX1988/openpilot that referenced this pull request Feb 22, 2026
* Updated PIN control

* Okay good to know

* Remove clear PIN behavior

* Added stable menu to mici
66thparallel pushed a commit to 66thparallel/janes_openpilot_fork that referenced this pull request May 1, 2026
Refactor cross-platform libc usage
old-commit-hash: 6ab4ac2
dyl10s pushed a commit to dyl10s/openpilot that referenced this pull request Aug 12, 2026
…braking-issue-in-chill-mode

Restore minimum lead-tracking buffer to fix chill-mode lead stopping
dyl10s pushed a commit to dyl10s/openpilot that referenced this pull request Aug 13, 2026
…braking-issue-in-chill-mode

Restore minimum lead-tracking buffer to fix chill-mode lead stopping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants