Conversation
Contributor
|
| Make | Model | Supported Package | ACC | No ACC accel below | No ALC below | Steering Torque | Resume from stop | Hardware Needed | Video |
|---|---|---|---|---|---|---|---|---|---|
| Toyota | RAV4 2023 ➡️ RAV4 2023-24 | All | Stock | 0 mph | 0 mph |  |
 |
Parts- 1 RJ45 cable (7 ft)- 1 Toyota A connector - 1 comma 3X - 1 comma power v2 - 1 harness box - 1 mount - 1 right angle OBD-C cable (1.5 ft) Buy Here Parts- 1 RJ45 cable (7 ft)- 1 Toyota A connector - 1 comma 3X - 1 comma power v2 - 1 harness box - 1 mount - 1 right angle OBD-C cable (1.5 ft) Buy Here |
66thparallel
pushed a commit
to 66thparallel/janes_openpilot_fork
that referenced
this pull request
May 1, 2026
* add 2024 RAV4 ICE FP * docs * also try vin bus 0 toyota * it works! old-commit-hash: ca57d32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICE version of #30887
Dongle: 034c992cd2367de4
The user was on a fork without the 2024 RAV4 hybrid FP, but even with it, it fails to fuzzy fingerprint due to the ABS FW version being too different.
The reason we look at the ABS FW version for the Toyota's fuzzy fingerprinting was because it was unique enough to differentiate hybrid and ICE models back before we started combining them, but now that we combined platforms, we don't really need this ECU any more. This PR is an example of it being too strict, since we now consider ICE and hybrid to have the same API (for the most part, more on that below).
Of the Toyota FP PRs since we started merging the platforms, using
fwdRadarinstead ofabsdefinitely would have made a fair amount of those PRs not needed since we merged the hybrid platforms. We need to solve these problems first though (by detecting them independent of ICE/hybrid): #28641 (comment)