Skip to content

hypothesis: fix too slow health check - #30001

Merged
sshane merged 2 commits into
masterfrom
test-interfaces-health
Sep 22, 2023
Merged

sshane merged 2 commits into
masterfrom
test-interfaces-health

Conversation

@sshane

@sshane sshane commented Sep 21, 2023 •

Copy link
Copy Markdown
Collaborator

Pinned in #24852. Version is from May 2022, time we upgrade.

Also fixes a slowness health check bug in jenkins CI when the machine is under load from other tests. Generation hangs or is generally slow and the check trips on a few cases.

Ran locally with 500 pytest jobs and 6.47.1 is the first version that doesn't fail the check.


Related discussion in hypothesis repo about similar issue in CI: HypothesisWorks/hypothesis#2195 (comment)

@sshane

sshane commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator Author

It was an issue with pipenv:

~/openpilot$ pipenv lock fails with an obscure error message. It seems to be related to this package: exceptiongroup. Will look into it tomorrow.

After a very precise binary search. Found that it was the newest hypothesis version messing up with exceptiongroup

@sshane
sshane force-pushed the test-interfaces-health branch from 5a5b920 to 0e9d3f1 Compare September 22, 2023 00:24
@sshane sshane changed the title hypothesis: update to latest version hypothesis: fix too slow health check Sep 22, 2023
@sshane
sshane merged commit fb8f7ba into master Sep 22, 2023
@sshane
sshane deleted the test-interfaces-health branch September 22, 2023 00:40
66thparallel pushed a commit to 66thparallel/janes_openpilot_fork that referenced this pull request May 1, 2026
* update hypothesis

* change less
old-commit-hash: fb8f7ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant