Skip to content

GM: handle run-away set speed - #26480

Merged
sshane merged 11 commits into
masterfrom
gm-handle-multi-presses
Nov 12, 2022
Merged

sshane merged 11 commits into
masterfrom
gm-handle-multi-presses

Conversation

@sshane

@sshane sshane commented Nov 12, 2022 •

Copy link
Copy Markdown
Collaborator

Matches Hyundai's code path of making sure we add button events for both buttons if the value transitions from one button to another without first going to unpressed.

Only doing on a make by make basis as this has controls-mismatch implications.

Pre-req for #26442

@sshane sshane added car vehicle-specific gm labels Nov 12, 2022
@sshane sshane changed the title GM: Handle run-away set speed GM: handle run-away set speed Nov 12, 2022
@sshane
sshane merged commit 65f494d into master Nov 12, 2022
@sshane
sshane deleted the gm-handle-multi-presses branch November 12, 2022 10:02
deanlee pushed a commit to deanlee/openpilot that referenced this pull request Nov 13, 2022
* GM: Handle run-away set speed

* bumpo

* This is a test of both PRs combined

* tempbump

* Revert "tempbump"

This reverts commit b73e04f.

* Revert "This is a test of both PRs combined"

This reverts commit 22cc0e6.

* fix

* bump

* fix that

* Bump to master

* fix fix
66thparallel pushed a commit to 66thparallel/janes_openpilot_fork that referenced this pull request May 1, 2026
* GM: Handle run-away set speed

* bumpo

* This is a test of both PRs combined

* tempbump

* Revert "tempbump"

This reverts commit b73e04f.

* Revert "This is a test of both PRs combined"

This reverts commit 22cc0e6.

* fix

* bump

* fix that

* Bump to master

* fix fix
old-commit-hash: 65f494d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

car vehicle-specific gm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant