Repository navigation
HKG: resume from standstill for HDA1 CAN-FD - #26069
Merged
adeebshihadeh merged 11 commits intoOct 19, 2022
Merged
Conversation
Contributor
|
Also interested in seeing this get merged! |
sshane
reviewed
Oct 13, 2022
sshane
reviewed
Oct 17, 2022
sshane
reviewed
Oct 17, 2022
Contributor
Author
|
Current code works! |
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
…e-from-standstill
adeebshihadeh
changed the title
Contributor
|
Thanks for all the work on HDA1 @hoomoose! |
66thparallel
pushed a commit
to 66thparallel/janes_openpilot_fork
that referenced
this pull request
May 1, 2026
* Cruise Button Press on bus 6 for HDA1 Canfd * use bus helper * Update hyundaicanfd.py * Update hyundaicanfd.py * Update hyundaicanfd.py * Update hyundaicanfd.py * Update selfdrive/car/hyundai/hyundaicanfd.py Co-authored-by: Shane Smiskol <shane@smiskol.com> * Update selfdrive/car/hyundai/hyundaicanfd.py Co-authored-by: Shane Smiskol <shane@smiskol.com> * bump panda Co-authored-by: Shane Smiskol <shane@smiskol.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> old-commit-hash: 3ee8572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resume from Standstill does not work for HKG Can-FD cars with HDA1. This is fixed by putting the can send for Cruise Buttons on bus 6 rather than bus 5. The fix requires an IF statement, which I have not written since I am not sure how to do so.
This fix only solves the problem for HDA1 cars with the 0x1cf signal like the EV6 and I5.
Solves issue: #25771
Prerequisite
This requires a simple Panda change on L39 of safety_hyundai_canfd.h
Bus 0 needs to be bus 2. That is it.
see: commaai/panda#1102
Verification
This fix has been employed in a fork hoomoose:hda1ev6i5 written specifically for hda1 ev6 and I5 cars and has been successfully tested/used by many!