Repository navigation
Conversation
sshane
changed the title
sshane
changed the title
Collaborator
Author
|
Even with the torque threshold bump, driver and EPS torque signals are much too noisy to consistently rely on right now. Driver torque going from 385 to 14 in one frame: |
Collaborator
Author
|
This PR did this: #24901 |
Contributor
|
Done in 2210868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our torque limits and steering pressed logic assumes the original Hyundai scaling, but the signal on HDA2 cars is 4x in max value, causing torque to wind down when not touching the wheel.
https://imgur.com/a/9SfUxMq