Skip to content

UI: don't block UI on vipc recv - #22644

Merged
adeebshihadeh merged 3 commits into
masterfrom
fix-ui
Oct 22, 2021
Merged

adeebshihadeh merged 3 commits into
masterfrom
fix-ui

Conversation

@adeebshihadeh

Copy link
Copy Markdown
Contributor

fixes #22257

@deanlee

deanlee commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

it's much simpler. but looks like the drawing frequency will be very unstable, I have added output to print the frequency of update (repaint):
26.683940 ms
65.792258 ms
57.697847 ms
52.284531 ms
61.280981 ms
7.577666 ms

And updateFrame will be called very frequently:
time interval 11.412904
time interval 11.487633
time interval 11.558782
time interval 61.483100
time interval 0.003596
time interval 0.169086
time interval 0.248513
time interval 0.316062

#22354 will be more stable:
59.103071 ms
52.200062 ms
54.793816 ms
51.418571 ms

@adeebshihadeh

Copy link
Copy Markdown
Contributor Author

I noticed the same thing. Looks like I misunderstood the aboutToCompose signal. This is the issue.

@pd0wm pd0wm added the bugfix label Oct 22, 2021
@adeebshihadeh
adeebshihadeh merged commit c4de1fe into master Oct 22, 2021
@adeebshihadeh
adeebshihadeh deleted the fix-ui branch October 22, 2021 21:16
66thparallel pushed a commit to 66thparallel/janes_openpilot_fork that referenced this pull request May 1, 2026
* UI: don't block UI on vipc recv

* use a timer

* move that
old-commit-hash: c4de1fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C3: UI state updates at 10Hz

3 participants