Repository navigation
sim: fix race condition in tmux script - #22365
Merged
Merged
Conversation
adeebshihadeh
changed the title
66thparallel
pushed a commit
to 66thparallel/janes_openpilot_fork
that referenced
this pull request
May 1, 2026
* carla simulator tmux script enhancement * real name Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> old-commit-hash: 8412f60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential bug fix at tools/sim/tmux_script.sh.
It can look as follows:
tmux aattaches to last used sessiontmux a -t htopwould always attach to session namedhtopAlthough bash scripts are fast and the bug I described is really not likely to happen, it's better to be cautious especially when the fix doesn't take away anything.