Skip to content

HKG: Add Car Port for 2021 Kia K5 - #22347

Merged
adeebshihadeh merged 6 commits into
commaai:masterfrom
sunnyhaibin:master-kia-k5-2021-port
Sep 30, 2021
Merged

adeebshihadeh merged 6 commits into
commaai:masterfrom
sunnyhaibin:master-kia-k5-2021-port

Conversation

@sunnyhaibin

Copy link
Copy Markdown
Contributor

Checklist

  • added to RELEASES, CARS
  • test route added to test_routes.py
  • route with openpilot: 007d5e4ad9f86d13|2021-09-25--11-23-14

Thanks to community Kia K5 owner 320Pilot.

Comment thread selfdrive/car/hyundai/values.py Outdated
@pd0wm pd0wm added the car port label Sep 25, 2021
Comment thread selfdrive/test/test_routes.py Outdated

@adeebshihadeh adeebshihadeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge once the test route gets uploaded

@adeebshihadeh

adeebshihadeh commented Sep 30, 2021 •

Copy link
Copy Markdown
Contributor

Thanks for another PR @sunnyhaibin! Next time, can you try to get a test route from the PR branch?

@adeebshihadeh
adeebshihadeh merged commit 6018bda into commaai:master Sep 30, 2021
@320Pilot

320Pilot commented Oct 1, 2021

Copy link
Copy Markdown

I see K5 Fw in master now, but not the Fingerprint.

@sunnyhaibin

Copy link
Copy Markdown
Contributor Author

Thanks for another PR @sunnyhaibin! Next time, can you try to get a test route from the PR branch?

Absolutely 👍

deanlee pushed a commit to deanlee/openpilot that referenced this pull request Oct 2, 2021
* HKG: Kia K5 2021 Car Port

* Update CARS.md and RELEASES.md

* Add test route: Kia K5 2021

* Update firmware format due to recent query change

* Update CARS.md: not all 2021 Kia K5 have SCC

* Update test_routes.py
66thparallel pushed a commit to 66thparallel/janes_openpilot_fork that referenced this pull request May 1, 2026
* HKG: Kia K5 2021 Car Port

* Update CARS.md and RELEASES.md

* Add test route: Kia K5 2021

* Update firmware format due to recent query change

* Update CARS.md: not all 2021 Kia K5 have SCC

* Update test_routes.py
old-commit-hash: 6018bda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants