add fingerprint for 2017 civic sport touring hatchback - #101
Closed
eschmidbauer wants to merge 1 commit into
Closed
eschmidbauer wants to merge 1 commit into
eschmidbauer wants to merge 1 commit into
Conversation
Contributor
|
Does this work? I thought there was a radar issue. |
Author
|
There is still an issue with the radar but this at least adds the fingerprint so the mph and rear camera work |
Contributor
|
My concern here is that it's sending messages out on the CAN bus that the car isn't listening for. Modify it to disable sending unused messages and we can upstream. |
Contributor
|
This code is definitely still sending commands. Would it make sense to officially add read-only support to openpilot? I have read-only code for some other cars without ACC/LKAS. |
Contributor
|
Yea, read only fingerprinting is good, just disable sends if we can't control the car. |
Contributor
|
If you disable sends when the fingerprint matches the hatchback, I'll merge this in. |
|
Sorry how do I disable sends,?
…On Jun 26, 2017 4:53 PM, "George Hotz" ***@***.***> wrote:
If you disable sends when the fingerprint matches the hatchback, I'll
merge this in.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZqy3aUvXF-Yc1jsTXVkQOuC6IbmXQXVks5sIChJgaJpZM4NzC7d>
.
|
Contributor
|
Check for fingerprint match in CarController and return early. |
geohot
pushed a commit
that referenced
this pull request
Apr 14, 2018
2253dd3 fix volt ign detect 3b299d7 add ignition and refactor af9af6d Merge pull request #110 from Jamezz/volt 13e850e more correct f295063 add new define to tests fec9758 gate that with debug 5516ebf one more ifdef cac7b31 only panda has float 938d474 fpu enable ffbf0c7 cleaner de30f27 Revert "need f to not be double" 4142acf need f to not be double 3eb15c8 refactor to share code a4c8b64 change to O2 to fix make recover 711fd11 Enable compiler optimizations, fix things it breaks 2e6f774 block IPAS in main toyota safety mode e7a2b3a add ipas tests 894572c fix tests 367c9ad add safety toyota ipas 95919b9 Bounty: panda high quality CAN autobaud (#96) 6557cd2 Toyota Safety: allow controls only on rising edge of cruise_engaged 02c1ddf Revert "added steer override check when IPAS is in control (#106)" 9f925ba Fix the merge mess 23d3833 Merge from comma upstream a0cc51a Undo safety mode override ea1c1dc make wlan interface name generic 6dbd8c9 Implement WebUSB and upgrade WinUSB to 2.0 (#107) 4fc83a5 Add safety hook for ignition and have GM use gear selector to determine ignition 52b2ac0 switch from travis to circleci 48e2374 build panda esp image 065572a circleci build stm image 7a1f319 add panda python package test and fix safety test 021dde7 move saftey test helper files into safety folder ce0545f add ci files 6a3307c no LIN over ELM 7d21acb added steer override check when IPAS is in control (#106) 1c88caf Safety code testing (#104) f4efd1f Merge pull request #101 from adhintz/master c02618b Merge pull request #102 from quillford/master 1ba5f8a added link to wiki for user scripts de2b19e add support for multiple buses to can_unique and can_bittransition output data in sorted order. git-subtree-dir: panda git-subtree-split: 2253dd3
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 30, 2019
add support for multiple buses to can_unique and can_bit_transition
pd0wm
pushed a commit
that referenced
this pull request
Nov 5, 2019
c0eba09 remove obsolete Subaru dbc file f7bce9e Fixes to vw dbc adb6726 Added VW comment about ignition bit c516316 Fixes and new message for VW MQB, fix for Accord Touring (#193) a09bf72 fixed to luxgen dbc file f00f628 Create luxgen_s5_2014.dbc (#101) 024612b Fix steer angle factor for toyota 7311ee7 Lexus is adjustment (#192) f04ce57 Updates for Volkswagen support (#191) git-subtree-dir: opendbc git-subtree-split: c0eba09
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this pull request
May 6, 2021
* add visionbuf make static ignore that * Needs decleration * add test binary * c++ * create some structure * some impl * socket stuff * Accept socket connection * Alloc some buffers * Create pub sockets and send buffer id * make listener private * Implement receive * use error check macros in cl_helpers * constructors to pass in opencl context * add some convenience values in struct * refactor creating buffers * rgb is not so simple * add fake stride and expose buffers * add comment * add extra data struct * support conflate * init opencl on all buffers * make ion compile * fix qcom2 * correctly setup yuv pointers when importing buffer * also included from c * Remove send print statements * send metadata * reveive metadata * also used in c code * dont start listener automatically * Was started in 2 places * set 100ms timeout on socket * verify server id to detect reconnects * handle reconnect * buffer cleanup * let user handle opencl creation * add default values * Add support for aligned rgb buffers * add align macro * dont use namespace * use poller * apple ifdef in ipc.cc * VisionBuf is C++ class * Install opencl headers * cppcheck c++ * remove c header guard * fix mac build * simplify constructors * Update visionipc/visionipc.h Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * Update visionipc/visionbuf_ion.cc Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> * add brackets * s/VIPCBufExtra/VisionIpcBufExtra/g * Add unittesting harness * remove vipc demo * very basic tests * add conflate test * Install opencl * suppress msgq warnings * Make it work using zmq * cl in qcom replay * run unittests in zmq mode as well * non blocking connect * always larger frame queues Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
carleeno
pushed a commit
to carleeno/openpilot
that referenced
this pull request
Aug 2, 2024
66thparallel
pushed a commit
to 66thparallel/janes_openpilot_fork
that referenced
this pull request
May 1, 2026
2253dd3 fix volt ign detect 3b299d7 add ignition and refactor af9af6d Merge pull request commaai#110 from Jamezz/volt 13e850e more correct f295063 add new define to tests fec9758 gate that with debug 5516ebf one more ifdef cac7b31 only panda has float 938d474 fpu enable ffbf0c7 cleaner de30f27 Revert "need f to not be double" 4142acf need f to not be double 3eb15c8 refactor to share code a4c8b64 change to O2 to fix make recover 711fd11 Enable compiler optimizations, fix things it breaks 2e6f774 block IPAS in main toyota safety mode e7a2b3a add ipas tests 894572c fix tests 367c9ad add safety toyota ipas 95919b9 Bounty: panda high quality CAN autobaud (commaai#96) 6557cd2 Toyota Safety: allow controls only on rising edge of cruise_engaged 02c1ddf Revert "added steer override check when IPAS is in control (commaai#106)" 9f925ba Fix the merge mess 23d3833 Merge from comma upstream a0cc51a Undo safety mode override ea1c1dc make wlan interface name generic 6dbd8c9 Implement WebUSB and upgrade WinUSB to 2.0 (commaai#107) 4fc83a5 Add safety hook for ignition and have GM use gear selector to determine ignition 52b2ac0 switch from travis to circleci 48e2374 build panda esp image 065572a circleci build stm image 7a1f319 add panda python package test and fix safety test 021dde7 move saftey test helper files into safety folder ce0545f add ci files 6a3307c no LIN over ELM 7d21acb added steer override check when IPAS is in control (commaai#106) 1c88caf Safety code testing (commaai#104) f4efd1f Merge pull request commaai#101 from adhintz/master c02618b Merge pull request commaai#102 from quillford/master 1ba5f8a added link to wiki for user scripts de2b19e add support for multiple buses to can_unique and can_bittransition output data in sorted order. git-subtree-dir: panda git-subtree-split: 2253dd3 old-commit-hash: e6e6ad2
66thparallel
pushed a commit
to 66thparallel/janes_openpilot_fork
that referenced
this pull request
May 1, 2026
c0eba09 remove obsolete Subaru dbc file f7bce9e Fixes to vw dbc adb6726 Added VW comment about ignition bit c516316 Fixes and new message for VW MQB, fix for Accord Touring (commaai#193) a09bf72 fixed to luxgen dbc file f00f628 Create luxgen_s5_2014.dbc (commaai#101) 024612b Fix steer angle factor for toyota 7311ee7 Lexus is adjustment (commaai#192) f04ce57 Updates for Volkswagen support (commaai#191) git-subtree-dir: opendbc git-subtree-split: c0eba09 old-commit-hash: 67c4121
bubbastumble
pushed a commit
to bubbastumble/openpilot_KL
that referenced
this pull request
Sep 4, 2026
Fix StreamRequestBody initialization for legacy and multi-camera clients, ignore unknown request fields, and use the supported nonblocking Params API for keyframe requests. Add regression coverage for request normalization. Based on PR commaai#101 by inauner: firestar5683#101
dirkpetersen
added a commit
to dirkpetersen/pnw-pilot
that referenced
this pull request
Sep 14, 2026
…7bad867 Housekeeping pass (owner request 2026-09-13). Since the mapd231pin2pnw commit (848f900), the stock mapd_release.json pin is v2.3.1. The device actually runs a custom override build, sha 77bad867 (upstream main f374b2b = v2.3.1 + FrogAi commaai#101/commaai#103/commaai#105/commaai#107/commaai#116 + our tile-validation commit aa04ba4), held by /data/mapd/.override. Update the three docs that still described the pin as v2.0.6. Not touched: selfdrive/controls/lib/ces_pnw/ces_pnw.py:2142, which also has a stale "the pin is v2.3.0" comment -- that file has two other agents editing it concurrently (wt-curvelead, wt-sazoneset), so its fix is reported separately for manual application after those merge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FwdRXRST5H2Hoft9yDkyU3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.