Added EPB and Brake_Hold - #61
Merged
Merged
Conversation
rbiasini
reviewed
Dec 21, 2017
| SG_ CHECKSUM : 51|4@0+ (1,0) [0|3] "" EON | ||
|
|
||
| BO_ 450 XXX_6: 8 XXX | ||
| SG_ EPB_Brake_and_Pull_Indicator : 6|1@0+ (1,0) [0|1] "" XXX |
Contributor
There was a problem hiding this comment.
@joeljacobs can you use CAPITAL notation here too? other than that it looks good
chrispypatt
pushed a commit
to chrispypatt/opendbc
that referenced
this pull request
Feb 2, 2025
* add json * empty to test * add generator * generated * add print * more abstract * rename * generated * add test to ensure list always syncs with the docs * attempt to fail the test * fix path * correct path * fail test intentionally * Revert "fail test intentionally" This reverts commit bf456ba. * start clean * dump back * update name * new list * generate extra list * single list is fine * more precision search * set while initializing * tldr * generate `car.CarParams.brand` in json * unused * generate no car docs platforms * include all dashcamOnly platforms * do not include dashcamOnly yet
eli-davis
pushed a commit
to eli-davis/opendbc_reference
that referenced
this pull request
Jul 15, 2025
* Added EPB and Brake_Hold * Fixed formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searched through Cabana with @energee to find proper signals for EPB and Brake_Hold. We found them.