Repository navigation
Kernel: what happens to a Finding that does not gate - #96
Merged
Merged
Conversation
The Maintainer's ruling on the story, option 1: a required Lens's Finding that does not gate, a minor or info one of any category but security, is an annotation on its Lens's check run. It has no Disposition and closes when its Lens stops reporting it, as a mechanical Finding does, so FR-33 and I-15 apply to gating Findings only. A security Finding gates at any severity: severity is never how a security defect gets merged. Threads gain category in the facts schema, the example, the counter-examples, tests/support.py and sim/world.py, in the authority table's terms, with null for a Lens that writes it only as prose. Two counter-examples refuse a thread without its category and one nobody owns, and check_authority now holds the thread's categories to the Finding's. gating_threads stays the one definition of a gating thread, so gates(), the queue's gate_open and moved_at all read the new rule. A minor or info security Finding sends the item to addressing with findings_open, and takes a queued item out with gate_open. One from a Lens that is not required gates only once a required Lens adopts it, whatever its category. Two mutants: one reads security by severity, one lets an unrequired Lens's security Finding gate. Refusing a Result that posts a Finding that does not gate on a thread is waiting on harness/, recorded in decision 0012. PRD FR-33, design §1.1, §3.7, §4.2, §4.3, I-15 and §9.9, and decision 0012 say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the review and security passes on the Finding that does not gate. A required model Lens's open thread whose category or severity is missing, null, or a word the Finding schema does not name is unreadable, not "not security": it could be a security Finding, which gates at any severity. The Kernel defers, reason thread_unreadable, with the thread's id as evidence, and the item is the Maintainer's to see. It is read just after the reviews, as an unreadable review is, and a queued item dequeues on it. It is read on a dependency update too, as a model Lens's thread gates whatever the class. A thread from a Lens that is not required may carry neither, and a person's thread gates whatever it says. The null-severity security case that had gated now defers. CATEGORIES and SEVERITIES join kernel/terms.py, and check_authority holds them to the Finding schema, and reports a facts schema whose threads carry no category rather than raising. thread() in tests/support.py keeps a category of None as None. Seven mutants. A correction to the last commit's message: moved_at does not read gating_threads. It counts a thread by any writer or Lens's App (moves()), so a security Finding of any severity moved an item before this story and still does. The design's facts table and §3.7 say a required Lens's thread takes its category and severity from that Lens's own Finding record in its Run's result.json, joined by surface.key, never from the comment text, which anyone with write access can edit. The reader App, which reads facts.threads, now lists records.artifacts under the actions: read it already holds; the Controller listed it. Decision 0012 records the join as waiting on adapters/. FR-33, design §4.2 item 2 and decision 0012 are narrowed to what the Kernel holds: a required model Lens's thread gates at any severity when it is security; a required deterministic Lens gates through its check's conclusion. Design §9.9 records that code scanning's default fails only on a security alert of high or higher, so its threshold must be set to fail on any (issue #95). The simulator's pr-review no longer opens a thread for a minor Finding that is not security, since the Harness refuses one, and a human thread in tests/test_simulator.py gains its category. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the epic "Epic: nine gaps in the Kernel, found in review". Closes #55.
Convergence read only Findings of severity
blockingormajor, so aminororinfoFinding could be open, with no Disposition, when its item merged, against FR-33 and I-15. The Maintainer ruled on 2026-10-14: a Finding that does not gate is an annotation on its Lens's check run, exempt from FR-33 and I-15, and asecurityFinding gates at any severity.The rule
security, any severity (blocking,major,minor,info)addressing/findings_open; queued,dequeue/gate_openblockingormajorminororinfothread_unreadable,needs_you; queued,dequeuehighor higher, so a lower security alert passes it: that is "Code scanning fails on a security alert of any severity" (Code scanning fails on a security alert of any severity #95), recorded in §9.9.categoryandseveritycome from the required Lens's own Finding record in its Run'sresult.json, joined bysurface.key, never from the comment text, which anyone with write access can edit. The join waits onadapters/.harness/(acceptance criterion 3), recorded in decision 0012, design §3.7, §4.3 and §9.9.Acceptance criteria
categoryis required on threads inschemas/facts.schema.json,examples/facts.json,tests/support.pyandsim/world.py, with counter-examples for a missing category and one nobody owns.tools/check_authority.pychecks that a thread's categories, and the Kernel'sCATEGORIESandSEVERITIES, are exactly a Finding's.test_a_minor_security_finding_gates,test_a_minor_security_finding_opened_while_queued_takes_it_out_of_the_queue,test_a_security_finding_from_a_lens_that_is_not_required_does_not_gateandtest_a_required_lens_thread_that_cannot_be_read_defers;test_minor_finding_and_unrequired_lens_do_not_gatestill passes. Mutants for reading security by severity, a non-required Lens gating, and each unreadable case: 146 of 146 killed.harness/, as above.config/apps.json(the reader App readsrecords.artifactsunder theactions: readit already holds).Read by
A fresh-context review and a separate security pass (Claude), on the first commit; the second commit answers them. Both found that a required Lens's thread with a null category was read as not security, so a minor security Finding could merge; it now defers. AGY (Gemini) to follow; Codex and CodeRabbit are at their usage limits.
make verifypasses on agit archiveexport (343 tests), andpython3 -m tools.mutantskills 146 of 146.🤖 Generated with Claude Code