Repository navigation
CodeRabbit comments and never requests changes - #40
Conversation
Under the ruleset on main a pull request needs no approving review, yet a "changes requested" review from CodeRabbit blocked two pull requests whose required check had passed. The design's rule is that a third-party reviewer informs and gates only through the in-house one (§4.2), and that any feature by which a reviewer approves once its threads are resolved is switched off. The key and its meaning were read from CodeRabbit's published schema, not guessed. The org's other repos set the same value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
Warning This pull request changes a CodeRabbit configuration file. Because it comes from a fork or its author is not a repository collaborator, reviews use only the configuration from the target branch. The proposed configuration will take effect after it is merged.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeAnt PR Risk: Low Risk
Assessed commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6edfec3abb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A reviewer pointed out that a repo file without `inheritance: true` replaces the org's settings rather than adding to them. That is intended here, and is now written down: the file is the whole configuration, so that what governs a review of this repo is in the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
What this is
One file,
.coderabbit.yaml, with one setting: CodeRabbit comments and never requests changes.Why
The ruleset on
mainasks for no approving review. Even so, two pull requests whose required check had passed could not merge, because CodeRabbit's review said "changes requested":The design's rule is that a third-party reviewer informs, and gates only through the in-house reviewer; and that any feature by which a reviewer approves once its threads are resolved is switched off, in that reviewer's configuration file in the repo (
docs/architecture/software-factory-design.md, §4.2). Its findings still arrive as threads.How the setting was chosen
Read from CodeRabbit's published schema, not guessed:
reviews.request_changes_workflow, a boolean, described there as approving automatically once its comments are resolved. The org's other repos set it tofalsein the same file.Not verified
main. If frommain, the two pull requests above stay blocked until this has merged and their standing reviews are dismissed.Verification
make verifypasses here, and on a local merge with the branchslice-0/context-engineering, whose checks read every file in the repo.🤖 Generated with Claude Code