Repository navigation
STRING_KEYS no longer names model, which the run at 2.1.306 never showed (closes #247) - #300
Conversation
…wed (closes #247) The run recorded in trials/P-13.v2-1-306.json found strings under nine of the eleven keys; model held none, the model's name being a key of modelUsage and the value of canonicalModel. tool_name stays, as a refused tool would fill it. TrialScript pins the list, and the stand-in plants a word under model, which a mutant that names it again lets through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nt says one list serves every field Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 52 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Closes #247: STRING_KEYS names one key fewer, as the run at 2.1.306 showed.
What the run showed (
trials/P-13.v2-1-306.json, merged in #291):type,subtype,stop_reason,service_tier,inference_geo,speed,canonicalModel,providerandcostBasis.tool_nameis reached only when a tool is refused, and that run refused none.modelappeared nowhere. The model's name is a key ofmodelUsageand the value ofcanonicalModel, never under a keymodel.The change:
tools/trial_p13_cli.shdropsmodelfrom STRING_KEYS, so a word under that key is no longer kept. It keepstool_name, since another run may refuse a tool.TrialScriptpins the list as it pins KEPT_RESULT.model, so the test that no model text reaches OUT fails ifmodelis named again. A mutant that names it is killed.The other half of the item: decided, no per-field lists.
usageandmodelUsageheld numbers and seven code words under named keys (service_tier,inference_geo,speed,typeunderusage;canonicalModel,provider,costBasisundermodelUsage). One list already names just those words and the answer's own codes, so per-field lists would hold the same words. The script's comment says so, and the test now shows the dropped word recorded inmodel_text_removed.Verification.
make verifypassed in the worktree, with history, atSIM_SEEDS=40.Reviews. A fresh Claude review with a security pass on 14247d9 found no blocker and no major. It confirmed #247's other three items are on main (#263). Its minors are fixed in 30dc6b3. Muse not run (the Maintainer, 2026-10-20: Kernel/hook only).
🤖 Generated with Claude Code