Skip to content

ci(pr-review): pin to @pr-review/stable channel (ring-1 fan-out) - #262

Merged
don-petry merged 1 commit into
mainfrom
feat/pin-pr-review-stable
Jun 10, 2026
Merged

don-petry merged 1 commit into
mainfrom
feat/pin-pr-review-stable

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Ring-1 of the consumer fan-out (combsmith/.github-private#536).

Converts markets' pr-review.yml from the lossy wrapper chain (pr-review-reusable.yml@<sha> → pr-review.yml@main, no agent_ref, drops the classic PAT) to a direct pinned call: uses: …/pr-review.yml@pr-review/stable with agent_ref: pr-review/stable + secrets: inherit.

Gains: validated known-good version (not bleeding main); agent scripts pinned (#506); classic PAT for approvals (forwarded via inherit — fine-grained can't addPullRequestReview); modern triggers incl. check_suite (reviews at green CI).

Future promotions = moving pr-review/stable centrally; this file never changes again. After merge I'll validate a real review fires+approves (ring-1 healthy), then ring-2.

Convert the pr-review caller from the lossy wrapper (pr-review-reusable.yml@<sha>,
which pins pr-review.yml@main, passes no agent_ref, and drops the classic PAT) to
a direct, pinned call of pr-review.yml@pr-review/stable with agent_ref and
secrets: inherit. This gives markets:
- the validated known-good review version (not bleeding main),
- pinned agent scripts (#506),
- the classic PAT for approvals (DON_PETRY_BOT_GH_PAT_CLASSIC, forwarded via
  secrets: inherit — fine-grained PATs can't addPullRequestReview),
- modern triggers incl. check_suite (reviews at green CI; fixes the old
  synchronize-only model that never re-fired at green CI).

Ring-1 of combsmith/.github-private#536. Promotion = moving pr-review/stable
centrally; this file never changes again.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner June 10, 2026 03:42
Copilot AI review requested due to automatic review settings June 10, 2026 03:42
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 4 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 78b4aafa-9dd1-4702-8426-38cd8bcda136

📥 Commits

Reviewing files that changed from the base of the PR and between 0ed7423 and 1354b50.

📒 Files selected for processing (1)
  • .github/workflows/pr-review.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pin-pr-review-stable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 10, 2026 03:43
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
```
No actionable issues — the bot comment was empty, there are no open threads from the bot, and all completed CI checks passed or were skipped. The PR changes only update `.github/workflows/pr-review.yml` to pin the workflow to the `pr-review/stable` channel.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
No Tier 1 blockers. No open bot review threads. No actionable findings.
PR is clean and unblocked pending in-progress CI checks.
```

@don-petry
don-petry disabled auto-merge June 10, 2026 03:43
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Skipped (informational): 0
```
No action required — the PR is unblocked pending the in-progress copilot reviewer check completing.

@don-petry
don-petry enabled auto-merge (squash) June 10, 2026 03:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the repository’s PR Review agent workflow to the org’s pr-review/stable channel and updates the event triggers/inputs so markets consumes the centrally-promoted “known good” PR review workflow + agent scripts.

Changes:

  • Switch reusable workflow call to petry-projects/.github-private/.github/workflows/pr-review.yml@pr-review/stable and pass agent_ref: pr-review/stable with secrets: inherit.
  • Update trigger set (adds check_suite, pull_request_review, repository_dispatch) and refactors workflow_dispatch inputs to pr_url + flags.
  • Adjust permissions from a blank workflow-level block to explicit scopes (currently at workflow level).

Comment on lines +41 to +44
permissions:
contents: read
pull-requests: write
checks: read
Comment on lines 15 to 22
on:
check_suite:
types: [completed]
pull_request_review:
types: [submitted, dismissed]
pull_request:
types: [opened, synchronize, reopened]
pull_request_review_comment:
types: [created]
issue_comment:
types: [created]
types: [ready_for_review, reopened, synchronize]
workflow_dispatch:
@don-petry
don-petry merged commit a32864d into main Jun 10, 2026
24 checks passed
@don-petry
don-petry deleted the feat/pin-pr-review-stable branch June 10, 2026 03:45

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 1354b50c96eb108b1169446fb3424d22665828b4
Review mode: triage-approved (single reviewer)

Summary

Ring-1 fan-out: converts markets' pr-review.yml thin caller from the wrapper-chain pin (pr-review-reusable.yml@<sha>) to a direct call against pr-review.yml@pr-review/stable with matching agent_ref: pr-review/stable and secrets: inherit. Owner-authored, +43/-14 in a single workflow file. Triage tier classified this as low-risk; this confirmation review agrees.

Linked issue analysis

No closingIssuesReferences — this is a configuration refactor without a tracked issue. PR body references the parent fan-out task petry-projects/.github-private#536 and the pinned-scripts work in #506 as context, which is appropriate. No issue closure required.

Findings

  • Permissions explicit and minimal: contents: read, pull-requests: write, checks: read — scoped to what the reusable workflow needs (replaces prior permissions: {} which would have blocked the new reusable from acting).
  • Moving tag (@pr-review/stable) is intentional, not a slip: the PR body documents the central-promotion model (Future promotions = moving pr-review/stable centrally; this file never changes again). The reusable workflow lives in the same org (petry-projects/.github-private), so the trust model matches existing org-internal automation. agent_ref pins the agent scripts to the same channel, keeping logic + scripts in lockstep.
  • Trigger surface refresh: drops pull_request_review_comment and issue_comment (now handled centrally via repository_dispatch: pr-review-mention), adds check_suite: completed and pull_request_review: [submitted, dismissed], narrows pull_request types to [ready_for_review, reopened, synchronize]. Matches the validated template noted in the PR body.
  • Concurrency block removed: now owned by the reusable workflow — correct delegation.
  • No secrets, credentials, migrations, or untrusted code execution introduced. secrets: inherit forwards DON_PETRY_BOT_GH_PAT_CLASSIC as called out in the body (fine-grained PATs can't addPullRequestReview).

CI status

All required checks green or correctly skipped: AgentShield, CodeQL (actions), SonarCloud, Secret scan (gitleaks), dependency-audit dispatch, dev-lead dispatch, pr-auto-review check-and-dispatch all SUCCESS. Language-specific CI (Backend/Frontend, npm/pnpm/govulncheck/cargo/pip audits) appropriately skipped for a workflow-only change. No failing or pending checks.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

don-petry added a commit that referenced this pull request Jun 19, 2026
Convert the pr-review caller from the lossy wrapper (pr-review-reusable.yml@<sha>,
which pins pr-review.yml@main, passes no agent_ref, and drops the classic PAT) to
a direct, pinned call of pr-review.yml@pr-review/stable with agent_ref and
secrets: inherit. This gives markets:
- the validated known-good review version (not bleeding main),
- pinned agent scripts (#506),
- the classic PAT for approvals (DON_PETRY_BOT_GH_PAT_CLASSIC, forwarded via
  secrets: inherit — fine-grained PATs can't addPullRequestReview),
- modern triggers incl. check_suite (reviews at green CI; fixes the old
  synchronize-only model that never re-fired at green CI).

Ring-1 of combsmith/.github-private#536. Promotion = moving pr-review/stable
centrally; this file never changes again.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants