Repository navigation
ci(pr-review): pin to @pr-review/stable channel (ring-1 fan-out) - #262
Conversation
Convert the pr-review caller from the lossy wrapper (pr-review-reusable.yml@<sha>, which pins pr-review.yml@main, passes no agent_ref, and drops the classic PAT) to a direct, pinned call of pr-review.yml@pr-review/stable with agent_ref and secrets: inherit. This gives markets: - the validated known-good review version (not bleeding main), - pinned agent scripts (#506), - the classic PAT for approvals (DON_PETRY_BOT_GH_PAT_CLASSIC, forwarded via secrets: inherit — fine-grained PATs can't addPullRequestReview), - modern triggers incl. check_suite (reviews at green CI; fixes the old synchronize-only model that never re-fired at green CI). Ring-1 of combsmith/.github-private#536. Promotion = moving pr-review/stable centrally; this file never changes again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 4 minutes and 15 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
There was a problem hiding this comment.
Pull request overview
Pins the repository’s PR Review agent workflow to the org’s pr-review/stable channel and updates the event triggers/inputs so markets consumes the centrally-promoted “known good” PR review workflow + agent scripts.
Changes:
- Switch reusable workflow call to
petry-projects/.github-private/.github/workflows/pr-review.yml@pr-review/stableand passagent_ref: pr-review/stablewithsecrets: inherit. - Update trigger set (adds
check_suite,pull_request_review,repository_dispatch) and refactorsworkflow_dispatchinputs topr_url+ flags. - Adjust permissions from a blank workflow-level block to explicit scopes (currently at workflow level).
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| checks: read |
| on: | ||
| check_suite: | ||
| types: [completed] | ||
| pull_request_review: | ||
| types: [submitted, dismissed] | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
| issue_comment: | ||
| types: [created] | ||
| types: [ready_for_review, reopened, synchronize] | ||
| workflow_dispatch: |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 1354b50c96eb108b1169446fb3424d22665828b4
Review mode: triage-approved (single reviewer)
Summary
Ring-1 fan-out: converts markets' pr-review.yml thin caller from the wrapper-chain pin (pr-review-reusable.yml@<sha>) to a direct call against pr-review.yml@pr-review/stable with matching agent_ref: pr-review/stable and secrets: inherit. Owner-authored, +43/-14 in a single workflow file. Triage tier classified this as low-risk; this confirmation review agrees.
Linked issue analysis
No closingIssuesReferences — this is a configuration refactor without a tracked issue. PR body references the parent fan-out task petry-projects/.github-private#536 and the pinned-scripts work in #506 as context, which is appropriate. No issue closure required.
Findings
- Permissions explicit and minimal:
contents: read,pull-requests: write,checks: read— scoped to what the reusable workflow needs (replaces priorpermissions: {}which would have blocked the new reusable from acting). - Moving tag (
@pr-review/stable) is intentional, not a slip: the PR body documents the central-promotion model (Future promotions = moving pr-review/stable centrally; this file never changes again). The reusable workflow lives in the same org (petry-projects/.github-private), so the trust model matches existing org-internal automation.agent_refpins the agent scripts to the same channel, keeping logic + scripts in lockstep. - Trigger surface refresh: drops
pull_request_review_commentandissue_comment(now handled centrally viarepository_dispatch: pr-review-mention), addscheck_suite: completedandpull_request_review: [submitted, dismissed], narrowspull_requesttypes to[ready_for_review, reopened, synchronize]. Matches the validated template noted in the PR body. - Concurrency block removed: now owned by the reusable workflow — correct delegation.
- No secrets, credentials, migrations, or untrusted code execution introduced.
secrets: inheritforwardsDON_PETRY_BOT_GH_PAT_CLASSICas called out in the body (fine-grained PATs can'taddPullRequestReview).
CI status
All required checks green or correctly skipped: AgentShield, CodeQL (actions), SonarCloud, Secret scan (gitleaks), dependency-audit dispatch, dev-lead dispatch, pr-auto-review check-and-dispatch all SUCCESS. Language-specific CI (Backend/Frontend, npm/pnpm/govulncheck/cargo/pip audits) appropriately skipped for a workflow-only change. No failing or pending checks.
Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.
Convert the pr-review caller from the lossy wrapper (pr-review-reusable.yml@<sha>, which pins pr-review.yml@main, passes no agent_ref, and drops the classic PAT) to a direct, pinned call of pr-review.yml@pr-review/stable with agent_ref and secrets: inherit. This gives markets: - the validated known-good review version (not bleeding main), - pinned agent scripts (#506), - the classic PAT for approvals (DON_PETRY_BOT_GH_PAT_CLASSIC, forwarded via secrets: inherit — fine-grained PATs can't addPullRequestReview), - modern triggers incl. check_suite (reviews at green CI; fixes the old synchronize-only model that never re-fired at green CI). Ring-1 of combsmith/.github-private#536. Promotion = moving pr-review/stable centrally; this file never changes again. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>



Ring-1 of the consumer fan-out (combsmith/.github-private#536).
Converts markets'
pr-review.ymlfrom the lossy wrapper chain (pr-review-reusable.yml@<sha>→pr-review.yml@main, noagent_ref, drops the classic PAT) to a direct pinned call:uses: …/pr-review.yml@pr-review/stablewithagent_ref: pr-review/stable+secrets: inherit.Gains: validated known-good version (not bleeding main); agent scripts pinned (#506); classic PAT for approvals (forwarded via inherit — fine-grained can't
addPullRequestReview); modern triggers incl.check_suite(reviews at green CI).Future promotions = moving
pr-review/stablecentrally; this file never changes again. After merge I'll validate a real review fires+approves (ring-1 healthy), then ring-2.