agent-ingress pr-review job pins the legacy bare pr-review/stable (DEFECTIVE PIN): move both pin lines to pr-review/v1-stable #520

Activity

1. don-petry

   added

   bugBug reportsBug reports

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Oct 10, 2026
2. don-petry commented on Oct 10, 2026

   

   don-petry

   on Oct 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #520 — agent-ingress pr-review job pins the legacy bare pr-review/stable (DEFECTIVE PIN): move both pin lines to pr-review/v1-stable

   Scope

   Repin the pr-review job in .github/workflows/agent-ingress.yml (uses: + agent_ref:) from pr-review/stable to pr-review/v1-stable in lockstep, and drop the DEFECTIVE PIN marker on that line.

   Pre-check (2026-10-10, git ls-remote petry-projects/.github-private): pr-review/stable → f6f2e384d6bf2f360acaf44eef0324632368394f (no ^{} peel entry was returned, so the ref resolves directly to this commit), pr-review/v1-stable → f6f2e384d6bf2f360acaf44eef0324632368394f. Identical, so I'll go ahead.

   Implementation Checklist

   • .github/workflows/agent-ingress.yml: change the two pin lines and remove the # DEFECTIVE PIN — see §5 marker (keep the NOSONAR marker)
   • Docs: the ingress collapse package (docs/initiatives/agent-ingress-collapse-markets.md) isn't in this repo, so there's no in-repo §5 doc to update

   Tests to Write

   • .github/scripts/tests/agent-ingress-workflow.bats: update the pin-parity assertions to expect pr-review/v1-stable, and assert the DEFECTIVE PIN marker is gone from the pr-review uses: line

   Test Command

   bats .github/scripts/tests/agent-ingress-workflow.bats
3. don-petry commented on Oct 10, 2026

   

   don-petry

   on Oct 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Progress (in progress — not yet durable)

   Provisional. Nothing is pushed yet. The automation posts the authoritative completion record (with PR number + head SHA) after the push. Read the notes below as intent, not delivered results.

   Plan Execution (intended)

   • Repinned the pr-review job's uses: and with.agent_ref from pr-review/stable to pr-review/v1-stable together. Removed the # DEFECTIVE PIN — see §5 marker and kept the # NOSONAR(githubactions:S7637) first-party channel ref marker.
   • No other part of agent-ingress.yml was touched: the if: filter, job-level concurrency: and ci-failure-analyst pin are unchanged.

   Pin resolution at implementation time (for the PR description, AC #3)

   git ls-remote https://github.com/petry-projects/.github-private.git on 2026-10-10:

   • pr-review/stable → f6f2e384d6bf2f360acaf44eef0324632368394f (no ^{} peeled entry was returned, so the tag ref resolves directly to this commit)
   • pr-review/v1-stable → f6f2e384d6bf2f360acaf44eef0324632368394f

   Same commit, so no build changes.

   Files touched (this workspace, not yet pushed)

   • .github/workflows/agent-ingress.yml: the two pin lines, plus the marker removal
   • .github/scripts/tests/agent-ingress-workflow.bats: the pin-parity test now expects pr-review/v1-stable. A new guard test checks that the pr-review uses: line pins @pr-review/v1-stable, keeps the NOSONAR marker and has no DEFECTIVE PIN marker. Both failed before the workflow edit.

   Notes

   • AC fix: remove gradle ecosystem from Dependabot config #4: the collapse package with §5 (docs/initiatives/agent-ingress-collapse-markets.md) lives in petry-projects/.github-private, not in this repo, so nothing in this repo needed updating. The §5 entry over there needs a separate follow-up.
   • .dev-lead/scripts/lib/ci-status.sh has a historical comment mentioning pr-review/stable. It's synced dev-lead tooling and doesn't describe this pin as defective, so I left it alone.
4. don-petry commented on Oct 10, 2026

   

   don-petry

   on Oct 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Implementation Complete — PR #521

   The implementation for issue #520 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

   • Pull request: feat: implement issue #520 — agent-ingress pr-review job pins the legacy bare pr-review/stable (DEFECTIVE PIN): move both pin lines to pr-review/v1-stable #521
   • Head commit: 3c781d3b844d69b1a78f944b8ca2d1116e0bc849
   • Net change against main: 2 file(s), +11/-4 lines
   • Run: https://github.com/petry-projects/markets/actions/runs/38049790426

   Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.
5. don-petry

   added a commit that references this issue on Oct 10, 2026

   feat: implement issue #520 — agent-ingress pr-review job pins the leg…

   ...

   62587ec
6. don-petry

   closed this as completedin #521on Oct 10, 2026