You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: implement issue #618 — Add persona-mention.yml to .prettierignore before the stub sync - #619
Add persona-mention.yml to .prettierignore before the stub sync
From the issue: The org-standard persona-mention.yml caller stub is about to be synced into this repo (combsmith/.github#781), and this repo's formatter will rewrite it.
Risk
Low — 1 file(s) changed; no CI- or runtime-critical paths touched.
Test plan
No test files were added or updated. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.
Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
This PR's CI checks (Lint + bats) are the success/regression signal.
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the .prettierignore file to exclude the .github/workflows/persona-mention.yml workflow from Prettier formatting. This prevents formatting changes that would cause byte-identity drift from the upstream standards-owned caller stub. There are no review comments, and the changes are appropriate.
Dev-Lead — waiting on PR blockers (intent: review-changes)
PR:#619
No changes were committed, but the PR still can't be marked done: required check dependency-audit / Detect ecosystems is still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-10-11T15:31:08Z
@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check dependency-audit / Detect ecosystems is still pending. I'll re-check automatically.
Next attempt after: 2026-10-11T15:31:08Z
Issues addressed: 0
- Codex Review Summary: neutral operational notice with no actionable findings [posted informational disposition]
Files changed: (none)
Skipped (informational): 1
```
The Codex review summary is a pure operational notice indicating that the code review completed successfully with no findings. The substantive review from `gemini-code-assist[bot]` confirms "there are no review comments, and the changes are appropriate." No code changes are required — the disposition clears the maintainer-comment gate.
No actionable code issues found. CodeRabbit's review confirms: no findings. All required CI checks have passed, including Node.js Tests, coverage, and build-and-test (which verify npm run check compliance). The change correctly adds persona-mention.yml to .prettierignore with proper documentation per issue #618 requirements. Ready to merge.
- Pre-merge check requesting evidence of `npm run check` is satisfied by passing CI
- The PR's change (adding `persona-mention.yml` to `.prettierignore`) correctly addresses issue #618
### Action Taken
Posted a single `informational` disposition reply to the original bot comment, noting that:
- All required CI checks have passed
- No code changes are required
- The PR is ready to merge
**Files changed:** None (no fixes needed; PR is already correct)
**Replied + disposition marker:** ✅ [Comment](https://github.com/petry-projects/google-app-scripts/pull/619#issuecomment-6111045763)
The harness will resolve the original bot comment and clear the maintainer-comment gate.
Neutral overview with no actionable findings — the PR's changes to add persona-mention.yml to .prettierignore are appropriate and all CI checks pass. No code changes needed.
Issues addressed: 0
Skipped (informational): 1 — CodeAnt's PR overview comment ("safe to merge") is a neutral summary with no actionable findings; dispositioned `informational`
Files changed: None
The PR is clear. The CodeAnt comment is a neutral overview acknowledging the changes are appropriate and the PR is safe to merge — not a concrete defect. All CI checks pass, no changes needed. I've dispositioned the comment so the maintainer-comment gate can clear it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-rebase:readyOpts a non-draft PR into auto-rebase without an approval (auto-rebase ready_label)
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Add persona-mention.yml to .prettierignore before the stub sync
From the issue: The org-standard
persona-mention.ymlcaller stub is about to be synced into this repo (combsmith/.github#781), and this repo's formatter will rewrite it.Risk
Low — 1 file(s) changed; no CI- or runtime-critical paths touched.
Test plan
No test files were added or updated. Verification:
bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
This PR's CI checks (Lint + bats) are the success/regression signal.
Closes #618
Summary by CodeRabbit