Skip to content

feat: implement issue #618 — Add persona-mention.yml to .prettierignore before the stub sync - #619

Merged
don-petry merged 1 commit into
mainfrom
dev-lead/issue-618-20261011-1457
Oct 11, 2026
Merged

don-petry merged 1 commit into
mainfrom
dev-lead/issue-618-20261011-1457

Conversation

@don-petry

@don-petry don-petry commented Oct 11, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Add persona-mention.yml to .prettierignore before the stub sync

From the issue: The org-standard persona-mention.yml caller stub is about to be synced into this repo (combsmith/.github#781), and this repo's formatter will rewrite it.

Risk

Low — 1 file(s) changed; no CI- or runtime-critical paths touched.

Test plan

No test files were added or updated. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the existing CI (bats + lint) guards the change.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's CI checks (Lint + bats) are the success/regression signal.

Closes #618

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Chores
    • Excluded an internal workflow file from automatic formatting.

@don-petry
don-petry requested a review from a team as a code owner October 11, 2026 14:58
@don-petry don-petry added the auto-rebase:ready Opts a non-draft PR into auto-rebase without an approval (auto-rebase ready_label) label Oct 11, 2026
@chatgpt-codex-connector

This comment has been minimized.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .prettierignore file to exclude the .github/workflows/persona-mention.yml workflow from Prettier formatting. This prevents formatting changes that would cause byte-identity drift from the upstream standards-owned caller stub. There are no review comments, and the changes are appropriate.

@coderabbitai

This comment has been minimized.

@codeant-ai

This comment has been minimized.

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #619
No changes were committed, but the PR still can't be marked done: required check dependency-audit / Detect ecosystems is still pending. The retry cron will re-attempt automatically. Next attempt after: 2026-10-11T15:31:08Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but I can't mark it done yet: required check dependency-audit / Detect ecosystems is still pending. I'll re-check automatically.
Next attempt after: 2026-10-11T15:31:08Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

No description provided.

@don-petry
don-petry disabled auto-merge October 11, 2026 15:30
@don-petry

Copy link
Copy Markdown
Collaborator Author

No actionable findings — Codex review completed with no issues identified. The code review confirms the changes are appropriate.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
- Codex Review Summary: neutral operational notice with no actionable findings [posted informational disposition]
Files changed: (none)
Skipped (informational): 1
```
The Codex review summary is a pure operational notice indicating that the code review completed successfully with no findings. The substantive review from `gemini-code-assist[bot]` confirms "there are no review comments, and the changes are appropriate." No code changes are required — the disposition clears the maintainer-comment gate.

@don-petry
don-petry enabled auto-merge (squash) October 11, 2026 15:31
@don-petry

Copy link
Copy Markdown
Collaborator Author

No description provided.

@don-petry
don-petry disabled auto-merge October 11, 2026 15:52
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) October 11, 2026 15:52
@don-petry

Copy link
Copy Markdown
Collaborator Author

No description provided.

@don-petry
don-petry disabled auto-merge October 11, 2026 16:16
@don-petry

Copy link
Copy Markdown
Collaborator Author

No actionable code issues found. CodeRabbit's review confirms: no findings. All required CI checks have passed, including Node.js Tests, coverage, and build-and-test (which verify npm run check compliance). The change correctly adds persona-mention.yml to .prettierignore with proper documentation per issue #618 requirements. Ready to merge.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
- Pre-merge check requesting evidence of `npm run check` is satisfied by passing CI
- The PR's change (adding `persona-mention.yml` to `.prettierignore`) correctly addresses issue #618
### Action Taken
Posted a single `informational` disposition reply to the original bot comment, noting that:
- All required CI checks have passed
- No code changes are required
- The PR is ready to merge
**Files changed:** None (no fixes needed; PR is already correct)  
**Replied + disposition marker:** ✅ [Comment](https://github.com/petry-projects/google-app-scripts/pull/619#issuecomment-6111045763)
The harness will resolve the original bot comment and clear the maintainer-comment gate.

@don-petry
don-petry enabled auto-merge (squash) October 11, 2026 16:17
@don-petry

Copy link
Copy Markdown
Collaborator Author

No description provided.

@don-petry
don-petry disabled auto-merge October 11, 2026 16:26
@don-petry

Copy link
Copy Markdown
Collaborator Author

Neutral overview with no actionable findings — the PR's changes to add persona-mention.yml to .prettierignore are appropriate and all CI checks pass. No code changes needed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0  
Skipped (informational): 1 — CodeAnt's PR overview comment ("safe to merge") is a neutral summary with no actionable findings; dispositioned `informational`  
Files changed: None  
The PR is clear. The CodeAnt comment is a neutral overview acknowledging the changes are appropriate and the PR is safe to merge — not a concrete defect. All CI checks pass, no changes needed. I've dispositioned the comment so the maintainer-comment gate can clear it.

@don-petry
don-petry enabled auto-merge (squash) October 11, 2026 16:27
@don-petry
don-petry merged commit 8c8d35e into main Oct 11, 2026
33 of 36 checks passed
@don-petry
don-petry deleted the dev-lead/issue-618-20261011-1457 branch October 11, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-rebase:ready Opts a non-draft PR into auto-rebase without an approval (auto-rebase ready_label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add persona-mention.yml to .prettierignore before the stub sync

1 participant