Skip to content

feat: implement issue #448 — Compliance: dev-lead-stub-agent-ref - #477

Merged
don-petry merged 1 commit into
mainfrom
dev-lead/issue-448-20260722-0520
Jul 22, 2026
Merged

don-petry merged 1 commit into
mainfrom
dev-lead/issue-448-20260722-0520

Conversation

@don-petry

@don-petry don-petry commented Jul 22, 2026 •

Copy link
Copy Markdown
Collaborator

User description

Closes #448

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated the development workflow to use the pinned stable dev-lead channel.
    • Aligned workflow references and configuration with the new channel version.

CodeAnt-AI Description

Point the dev-lead workflow at the v1-stable channel

What Changed

  • The dev-lead workflow now uses the v1-stable release channel instead of the older stable tag
  • The same v1-stable channel is passed through to the workflow setup so the caller and reusable workflow stay aligned

Impact

✅ Consistent dev-lead workflow releases
✅ Safer promotion of workflow updates
✅ Fewer mismatches between caller and reusable workflow

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@don-petry
don-petry requested a review from a team as a code owner July 22, 2026 05:24
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codeant-ai

codeant-ai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 03da849 Jul 22, 2026 · 05:24 05:25

Updated in place by CodeAnt AI · last 5 reviews

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5066aea2-d472-4c1e-a68d-05f2595a9960

📥 Commits

Reviewing files that changed from the base of the PR and between 386da8e and 03da849.

📒 Files selected for processing (1)
  • .github/workflows/dev-lead.yml

📝 Walkthrough

Walkthrough

The dev-lead reusable workflow reference, channel-pinning comment, and forwarded agent_ref input now consistently use dev-lead/v1-stable.

Changes

Dev-lead workflow channel

Layer / File(s) Summary
Update dev-lead channel pin
.github/workflows/dev-lead.yml
The reusable workflow and agent_ref input now target dev-lead/v1-stable instead of dev-lead/stable.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • petry-projects/ContentTwin, issue 341 — Both update the pinned dev-lead.yml channel reference for compliance.
  • petry-projects/markets, issue 327 — Both modify the dev-lead workflow channel pin, although that issue targets the stable channel.

Suggested reviewers: donpetry-bot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the compliance fix for issue #448 and matches the workflow change.
Linked Issues check ✅ Passed The workflow now forwards agent_ref to the pinned dev-lead channel and stays synchronized with the reusable template.
Out of Scope Changes check ✅ Passed The changes are limited to the requested workflow reference, comment, and forwarded input update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-448-20260722-0520

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Switch dev-lead workflow pin from dev-lead/stable to dev-lead/v1-stable

⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Pin dev-lead reusable workflow to the v1-stable channel to avoid self-host gating.
• Thread the same v1-stable ref via agent_ref for consistent agent checkout.
Diagram

graph TD
  A[".github/workflows/dev-lead.yml"] --> B["Reusable workflow"] --> C["dev-lead/v1-stable tag"]
  B --> D["agent_ref input"] --> C

  subgraph Legend
    direction LR
    _file["Workflow file"] ~~~ _wf["Reusable workflow"] ~~~ _tag["Channel tag"]
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Pin reusable workflow to an immutable commit SHA
  • ➕ Maximizes supply-chain safety and reproducibility (no moving tag)
  • ➕ Eliminates surprises from tag movement
  • ➖ Requires manual updates to roll forward
  • ➖ Harder to centrally promote hotfixes across repos compared to a channel tag
2. Use semantic major tag (e.g., dev-lead/v1) plus separate promotion process
  • ➕ Keeps stable-by-major semantics while reducing confusion around 'stable' naming
  • ➕ Allows v2 cutover without touching callers
  • ➖ Still a moving ref; needs disciplined release/promotion management
  • ➖ May require additional documentation/standards alignment

Recommendation: The PR’s approach (moving to a version-scoped stable channel) is a good balance: it preserves centralized promotion while reducing the risk of breaking changes landing in an unversioned 'stable' stream. If stronger reproducibility is needed, consider SHA pinning for high-security repos, but accept the operational overhead.

Files changed (1) +4 / -4

Other (1) +4 / -4
dev-lead.ymlPin dev-lead reusable workflow and agent_ref to dev-lead/v1-stable +4/-4

Pin dev-lead reusable workflow and agent_ref to dev-lead/v1-stable

• Updates the reusable workflow reference from dev-lead/stable to dev-lead/v1-stable and aligns the agent_ref input to the same channel. Comments are updated to reflect the new tag name and promotion model.

.github/workflows/dev-lead.yml

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jul 22, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #477
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-07-22T05:55:07Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-07-22T05:55:07Z

@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry enabled auto-merge (squash) July 22, 2026 05:25
@don-petry
don-petry disabled auto-merge July 22, 2026 05:25
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
No actionable findings — Quality Gate passed with 0 new issues and 0 security hotspots
Files changed: none required
Skipped (informational): 0
```
The PR is in good standing. No changes needed.

@don-petry
don-petry enabled auto-merge (squash) July 22, 2026 05:26
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-07-22T06:26:14Z.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@don-petry
don-petry disabled auto-merge July 22, 2026 06:44
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) July 22, 2026 06:44

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 03da849a8a6080f9354a618cb1a94bf2fed24748
Review mode: triage-approved (single reviewer)

Summary

One-file, 4-line change syncing the dev-lead.yml thin caller stub to the canonical template: the reusable-workflow pin and agent_ref both move from the dev-lead/stable channel tag to dev-lead/v1-stable. Verified the PR file is byte-for-byte identical to standards/workflows/dev-lead.yml in petry-projects/.github, and the dev-lead/v1-stable tag exists in petry-projects/.github-private. Both refs are first-party moving channel tags, so this is a low-risk config re-sync.

Linked issue analysis

Closes #448 (Compliance: dev-lead-stub-agent-ref). The weekly compliance audit required the caller stub to be re-synced from standards/workflows/dev-lead.yml so agent_ref matches the channel pin. The PR applies the remediation exactly as prescribed — the file now matches the canonical template verbatim, with uses: and agent_ref aligned on dev-lead/v1-stable. Issue substantively addressed.

Findings

No blocking findings.

  • Template conformance: PR head file is identical to the canonical template (full-file diff clean).
  • Ref validity: dev-lead/v1-stable tag exists in petry-projects/.github-private (verified via git/matching-refs).
  • Note: the issue body lists channels as stable/next/ring, but the authoritative template now uses the v1-* channel naming (v1-stable/v1-next/v1-ring tags all exist); the template is the source of truth.
  • Secret scan: run_secret_scanning MCP tool not available in this session; gitleaks CI check passed (no secrets in diff — comment/ref changes only).
  • No unresolved review threads; all PR comments are bot/automation status notes with no unanswered human questions.

CI status

All checks green: agent-shield, build-and-test, CodeQL (actions/js-ts/python), SonarCloud Quality Gate passed (0 new issues), Node.js Tests, Playwright UI Tests, coverage, gitleaks secret scan, npm audit, autofix — all SUCCESS. Remaining checks SKIPPED (not applicable: dependabot-automerge, pip/cargo/govulncheck/pnpm audits, dev-lead ci-relay).


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 2148a86 into main Jul 22, 2026
28 checks passed
@don-petry
don-petry deleted the dev-lead/issue-448-20260722-0520 branch July 22, 2026 07:28
don-petry added a commit that referenced this pull request Aug 4, 2026
Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: dev-lead-stub-agent-ref

2 participants