Skip to content

fix(api): bump Go toolchain to 1.26.2 for stdlib CVE fixes #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 4 commits into from
Apr 8, 2026
Merged

fix(api): bump Go toolchain to 1.26.2 for stdlib CVE fixes #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9d4134
fix(api): bump Go toolchain to 1.26.2 for stdlib CVE fixes
don-petry Apr 8, 2026
cf94d0c
fix(ci): bump setup-go to 1.26 and pin golangci-lint v2.11.4
don-petry Apr 8, 2026
321e153
fix(ci): bump golangci-lint-action v6 -> v8 to support golangci-lint v2
don-petry Apr 8, 2026
72497c6
fix(api): check fmt.Fprintf error in health handler
don-petry Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,23 @@ jobs:

- uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0
with:
go-version: "1.24"
go-version: "1.26"
cache-dependency-path: apps/api/go.sum

- name: Vet
run: go vet ./...

- name: Lint
uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6
uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
with:
working-directory: apps/api
# Pin golangci-lint to a release built with Go >= 1.26 so it
# can read the toolchain pin in apps/api/go.mod (go1.26.2).
# The action's default is built with Go 1.24 and refuses with:
# "the Go language version (go1.24) used to build
# golangci-lint is lower than the targeted Go version
# (1.26.2)"
version: v2.11.4

- name: Test
run: go test ./... -race -coverprofile=coverage.out
Expand Down
4 changes: 3 additions & 1 deletion apps/api/cmd/server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ func main() {

r.Get("/health", func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
fmt.Fprintf(w, `{"status":"ok"}`)
if _, err := fmt.Fprintf(w, `{"status":"ok"}`); err != nil {
log.Printf("health check: write response: %v", err)
}
})

addr := ":8080"
Expand Down
6 changes: 6 additions & 0 deletions apps/api/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,10 @@ module github.com/broodly/api

go 1.24

// Force toolchain to a Go version that includes the fixes for
// GO-2026-4866, GO-2026-4870, GO-2026-4946, GO-2026-4947 (all crypto/tls
// and crypto/x509 stdlib fixes shipped in 1.26.2). The `go` directive
// stays at 1.24 because no language features above that are used.
toolchain go1.26.2
Comment thread
don-petry marked this conversation as resolved.

require github.com/go-chi/chi/v5 v5.2.2
Loading