Skip to content

feat: implement issue #480 — Compliance: ruleset-drift-pr-quality-require_code_owner_review #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 3 commits into from
Aug 7, 2026
Merged

feat: implement issue #480 — Compliance: ruleset-drift-pr-quality-require_code_owner_review #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd99a59
feat: implement issue #480 — Compliance: ruleset-drift-pr-quality-req…
donpetry-bot Aug 7, 2026
bbab7ff
chore: dev-lead update (review-changes) [skip ci-relay]
donpetry-bot Aug 7, 2026
c46fd0e
chore: dev-lead update (review-changes) [skip ci-relay]
donpetry-bot Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ overrides:
brace-expansion: '>=5.0.8'
ws: '>=8.21.0'
form-data: '>=4.0.6'
js-yaml: '>=4.3.0 <5.0.0'
js-yaml: '>=4.3.1'
'@babel/core': ^7.29.6
'lodash@>=4.0.0 <=4.17.23': '>=4.18.0'
tmp: '>=0.2.6'
Expand Down
26 changes: 22 additions & 4 deletions tests/scripts/apply-rulesets.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
# Test: scripts/apply-rulesets.sh codifies the pr-quality and code-quality
# rulesets required by the org github-settings standard.
#
# Focus: the pr-quality `pull_request` rule must set
# dismiss_stale_reviews_on_push = true (compliance check
# ruleset-drift-pr-quality-dismiss_stale_reviews_on_push).
# Focus: the pr-quality `pull_request` rule must set the compliance-critical
# boolean parameters to true — dismiss_stale_reviews_on_push (compliance check
# ruleset-drift-pr-quality-dismiss_stale_reviews_on_push) and
# require_code_owner_review (ruleset-drift-pr-quality-require_code_owner_review).
# These are asserted as strict booleans so a string "true" cannot pass.
#
# Runs the script in --dry-run --force mode so no real GitHub API calls are
# made and the repo-identity safety check is skipped. Asserts the dry-run
Expand Down Expand Up @@ -84,6 +86,23 @@ else
fail=1
fi

# The compliance-critical parameter for #480: a code owner review must be
# required. Asserted as a strict boolean within the pr-quality ruleset so a
# string "true" or the setting appearing in another ruleset cannot pass.
_code_owner=$(jq -r '
.rules[]
| select(.type == "pull_request")
| (.parameters.require_code_owner_review // false)
| (type == "boolean" and . == true)
' <<< "$_pr_q_json")
if [[ "$_code_owner" = "true" ]]; then
echo "ok - pr-quality pull_request rule sets require_code_owner_review = true"
pass_count=$((pass_count + 1))
else
echo "not ok - pr-quality pull_request rule: require_code_owner_review not true (got: ${_code_owner:-missing})"
fail=1
fi

# Remaining standard pr-quality pull_request parameters — checked within the
# pr-quality ruleset object so a matching field in any other ruleset cannot
# produce a false pass.
Expand All @@ -104,7 +123,6 @@ _jq_check() {
}

_jq_check '.required_approving_review_count' '1' 'pr-quality requires 1 approving review'
_jq_check '.require_code_owner_review' 'true' 'pr-quality requires code owner review'
_jq_check '.require_last_push_approval' 'true' 'pr-quality requires last push approval'
_jq_check '.required_review_thread_resolution' 'true' 'pr-quality requires review thread resolution'

Expand Down
Loading