Repository navigation
feat: implement issue #407 — Compliance: ruleset-drift-pr-quality-require_code_owner_review - #433
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 45 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR consolidates repository coding standards in ChangesRepository coding standards
Shell test failure handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration test script tests/scripts/apply-rulesets.test.sh to verify that the apply-rulesets.sh script correctly codifies the required GitHub repository ruleset parameters (such as requiring code owner reviews). The feedback recommends enabling immediate exit on error with set -e (and safely capturing command exit codes), using a more idiomatic Bash here-string instead of piping printf to grep, and guarding the trap cleanup directory variable to prevent accidental deletions.
There was a problem hiding this comment.
Pull request overview
Adds a shell-based regression test to ensure the repository’s scripts/apply-rulesets.sh continues to emit a pr-quality ruleset payload that matches the org compliance standard (specifically guarding require_code_owner_review: true).
Changes:
- Introduces
tests/scripts/apply-rulesets.test.shwhich runsscripts/apply-rulesets.shin--dry-run --forcemode with a stubbedghbinary. - Asserts the emitted
pr-qualityruleset payload includesrequire_code_owner_review: trueplus related PR review requirements.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
🤖 CodeAnt AI — Review Status
|
codeant-ai
Bot
added
the
size:M
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
|
ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing |
codeant-ai
Bot
added
size:L
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CLAUDE.md`:
- Around line 129-137: Remove the duplicated Key Rules list in CLAUDE.md,
keeping a single complete copy with the existing Markdown structure and all
seven rules intact.
- Line 73: Remove or rename the duplicate `## Coding Standards` and `## Key
Differentiator: Zero-Tap Beeyard` headings in `CLAUDE.md` so each heading is
unique and markdownlint MD024 passes, while preserving the content of both
sections.
In `@tests/scripts/apply-rulesets.test.sh`:
- Line 29: Update the assert_contains failure message to reference its defined
parameters—needle, desc, and output—instead of unset expected and actual
variables, preserving the diagnostic context and allowing fail=1 to execute
under set -u.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 35f275e6-dc03-4a32-8391-a5198a589c76
⛔ Files ignored due to path filters (3)
_bmad-output/brainstorming/brainstorming-session-2026-03-14-134719.mdis excluded by!_bmad-output/**_bmad-output/planning-artifacts/broodly-prototype.htmlis excluded by!_bmad-output/**_bmad-output/planning-artifacts/product-brief-bmad-method-2026-03-15.mdis excluded by!_bmad-output/**
📒 Files selected for processing (3)
CLAUDE.mdtests/scripts/apply-repo-settings.test.shtests/scripts/apply-rulesets.test.sh
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
Dev-Lead — waiting on PR blockers (intent: fix-reviews)PR: #433 |
|
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #433 |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 135419e0313ad3b722c013db73a197ac19f3d4c2
Review mode: triage-approved (single reviewer)
Summary
Re-review after cycle-1/2 fix requests. Both prior MAJOR blockers are resolved: the branch is now MERGEABLE (conflicts with main resolved via merge commits c18a846/135419e0) and the full CI suite ran green on the head SHA (Shell Tests, gitleaks secret scan, CodeQL, SonarCloud, Go, TypeScript all SUCCESS). The residual diff vs main is small (6 files, +35/-9): correct set -euo pipefail hardening plus safe exit-code capture in both script tests, a CLAUDE.md heading rename, trailing-newline fixes, and a static Required Materials section in a planning-artifact prototype HTML. The issue-#407 guard assertion (require_code_owner_review=true) is present at head (tests/scripts/apply-rulesets.test.sh:107).
Linked issue analysis
Closes #407 (compliance: live pr-quality ruleset drifted on require_code_owner_review). The code-side guard — asserting the codified payload pins require_code_owner_review=true — is present at head (tests/scripts/apply-rulesets.test.sh:107). Most of the guard content now also exists on main (consolidated via sibling compliance PR #434 for issue #408), so this PR's remaining delta is the review-requested test hardening. The live ruleset drift itself is remediated operationally by running scripts/apply-rulesets.sh, as the issue states. The prior deep review already accepted this framing as a substantive response; that still holds.
Findings
- [RESOLVED] Prior MAJOR: merge state CONFLICTING/DIRTY — now MERGEABLE (mergeStateStatus BLOCKED only on required code-owner review, which this approval addresses).
- [RESOLVED] Prior MAJOR: main CI never ran on the reviewed SHA — full suite now ran on 135419e: Shell Tests, Secret scan (gitleaks), CodeQL (actions/go/js-ts), SonarCloud (0 new issues), Go, TypeScript, AgentShield all SUCCESS. The 'review / review' CANCELLED check is the review cascade itself, superseded by this run.
- [GOOD] Test hardening is correct: set -euo pipefail plus the 'exit_code=0; output=$(...) || exit_code=$?' capture pattern avoids the set -e early-exit pitfall — matches the applied Gemini/Copilot review feedback.
- [MINOR] Stale-branch residue unrelated to #407: CLAUDE.md heading rename ('Figma MCP Integration Rules' → 'Key Rules'), trailing-newline fixes in two _bmad-output docs, and a static Required Materials section in the prototype HTML. All are docs/planning-artifact files; CLAUDE.md has not changed on main since 2026-03, so nothing recent is being reverted. Benign scope creep, not blocking.
- [INFO] All 11 review threads (Gemini, Copilot, CodeAnt, CodeRabbit) are resolved; no unanswered human-reviewer questions.
- [NOTE] MCP run_secret_scanning tool unavailable in this run; manual diff scan found no secrets (only the explicit GH_TOKEN=dummy-token test stub) and the gitleaks CI check passed on head.
CI status
All required checks green on head 135419e: TypeScript, Go, Shell Tests, Secret scan (gitleaks), CodeQL (actions/go/javascript-typescript), SonarCloud (passed), AgentShield, dependency-audit (pnpm audit/govulncheck SUCCESS; others SKIPPED per ecosystem detection). 'review / review' CANCELLED is the superseded review-cascade run; dependabot-automerge SKIPPED (not a Dependabot PR).
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
User description
Closes #407
Implemented by dev-lead agent. Please review.
CodeAnt-AI Description
Add a required-materials checklist to the weekly beekeeping plan
What Changed
Impact
✅ Fewer forgotten beekeeping supplies✅ Clearer preparation for hive-specific tasks✅ More reliable repository checks💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
Documentation
Tests