Epic 10: Planning & Weekly Queue (Stories 10.1–10.5)

.github/workflows/ci.yml

@@ -17,9 +17,9 @@ jobs:
   typescript:
     name: TypeScript
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     env:
-      # Firebase Emulator config for tests — no real credentials needed
-      EXPO_PUBLIC_FIREBASE_USE_EMULATOR: 'true'
+      EXPO_PUBLIC_FIREBASE_USE_EMULATOR: "true"
       EXPO_PUBLIC_FIREBASE_PROJECT_ID: broodly-dev
     steps:
       - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
@@ -34,7 +34,7 @@ jobs:
       - run: pnpm install --frozen-lockfile
 
       - name: Format check
-        run: pnpm run format:check
+        run: pnpm -w run format:check
 
       - name: Lint
         run: pnpm run lint
@@ -50,65 +50,27 @@ jobs:
             exit 1
           fi
 
-      - name: Test
+      - name: Test with coverage
+        # Coverage (lcov + text-summary) is configured in apps/mobile/jest.config.js.
+        # Passing CLI flags here forwards a literal `--` through nested pnpm, making
+        # jest treat the flags as test-path patterns (0 matches → exit 1).
         run: pnpm run test
+        continue-on-error: false
 
-  mobile-build:
-    name: Mobile Build
-    runs-on: ubuntu-latest
-    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
-    needs: [typescript]
-    steps:
-      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
-
-      - uses: pnpm/action-setup@f40ffcd9367d9f12939873eb1018b921a783ffaa # v4
-
-      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
+      - name: Upload test artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
         with:
-          node-version: 20
-          cache: pnpm
-
-      - run: pnpm install --frozen-lockfile
-
-      - name: Generate .env from secrets
-        working-directory: apps/mobile
-        env:
-          EXPO_PUBLIC_FIREBASE_API_KEY: ${{ secrets.EXPO_PUBLIC_FIREBASE_API_KEY }}
-          EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN: ${{ secrets.EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN }}
-          EXPO_PUBLIC_FIREBASE_PROJECT_ID: ${{ secrets.EXPO_PUBLIC_FIREBASE_PROJECT_ID }}
-          EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET: ${{ secrets.EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET }}
-          EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID }}
-          EXPO_PUBLIC_FIREBASE_APP_ID: ${{ secrets.EXPO_PUBLIC_FIREBASE_APP_ID }}
-          EXPO_PUBLIC_API_URL: ${{ secrets.EXPO_PUBLIC_API_URL }}
-        run: |
-          cat > .env << 'ENVEOF'
-          EXPO_PUBLIC_FIREBASE_USE_EMULATOR=false
-          ENVEOF
-          echo "EXPO_PUBLIC_FIREBASE_API_KEY=${EXPO_PUBLIC_FIREBASE_API_KEY}" >> .env
-          echo "EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN=${EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN}" >> .env
-          echo "EXPO_PUBLIC_FIREBASE_PROJECT_ID=${EXPO_PUBLIC_FIREBASE_PROJECT_ID}" >> .env
-          echo "EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET=${EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET}" >> .env
-          echo "EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID=${EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID}" >> .env
-          echo "EXPO_PUBLIC_FIREBASE_APP_ID=${EXPO_PUBLIC_FIREBASE_APP_ID}" >> .env
-          echo "EXPO_PUBLIC_API_URL=${EXPO_PUBLIC_API_URL}" >> .env
-
-      - name: Inject native Firebase config (Android)
-        if: env.GOOGLE_SERVICES_JSON != ''
-        working-directory: apps/mobile
-        env:
-          GOOGLE_SERVICES_JSON: ${{ secrets.GOOGLE_SERVICES_JSON }}
-        run: echo "${GOOGLE_SERVICES_JSON}" | base64 -d > google-services.json
-
-      - name: Inject native Firebase config (iOS)
-        if: env.GOOGLE_SERVICE_INFO_PLIST != ''
-        working-directory: apps/mobile
-        env:
-          GOOGLE_SERVICE_INFO_PLIST: ${{ secrets.GOOGLE_SERVICE_INFO_PLIST }}
-        run: echo "${GOOGLE_SERVICE_INFO_PLIST}" | base64 -d > GoogleService-Info.plist
+          name: ts-test-results
+          path: |
+            apps/mobile/coverage/
+            test-results/
+          retention-days: 14
 
   go:
     name: Go
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     defaults:
       run:
         working-directory: apps/api
@@ -129,7 +91,7 @@ jobs:
           working-directory: apps/api
 
       - name: Unit tests
-        run: go test -short -race -coverprofile=coverage.out ./...
+        run: go test -short -race -coverprofile=coverage.out -timeout=5m ./...
 
       - name: Check coverage threshold
         run: |
@@ -142,10 +104,12 @@ jobs:
           fi
 
       - name: Upload coverage
+        if: always()
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
         with:
           name: go-coverage
           path: apps/api/coverage.out
+          retention-days: 14
 
       - name: Migration guard
         shell: bash
@@ -164,7 +128,6 @@ jobs:
 
           errors=0
 
-          # Collect sequence numbers and validate naming
           declare -A up_files
           declare -A down_files
           sequences=()
@@ -192,10 +155,8 @@ jobs:
             fi
           done
 
-          # Sort sequences
           IFS=$'\n' sorted=($(sort <<<"${sequences[*]}")); unset IFS
 
-          # Check each sequence has both up and down
           for seq in "${sorted[@]}"; do
             if [ -z "${up_files[$seq]}" ]; then
               echo "ERROR: Migration $seq is missing an .up.sql file"
@@ -207,7 +168,6 @@ jobs:
             fi
           done
 
-          # Check sequences are sequential (no gaps)
           prev=""
           for seq in "${sorted[@]}"; do
             if [ -n "$prev" ]; then
@@ -236,6 +196,7 @@ jobs:
   go-integration:
     name: Go Integration Tests
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     needs: go
     defaults:
       run:
@@ -249,5 +210,58 @@ jobs:
           cache-dependency-path: apps/api/go.sum
 
       - name: Integration tests (testcontainers)
-        run: go test -race -count=1 -run TestIntegration ./internal/repository/
-        timeout-minutes: 10
+        run: go test -race -count=1 -timeout=10m -run TestIntegration ./internal/repository/
+
+  mobile-build:
+    name: Mobile Build
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
+    needs: [typescript]
+    steps:
+      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
+
+      - uses: pnpm/action-setup@f40ffcd9367d9f12939873eb1018b921a783ffaa # v4
+
+      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
+        with:
+          node-version: 20
+          cache: pnpm
+
+      - run: pnpm install --frozen-lockfile
+
+      - name: Generate .env from secrets
+        working-directory: apps/mobile
+        env:
+          EXPO_PUBLIC_FIREBASE_API_KEY: ${{ secrets.EXPO_PUBLIC_FIREBASE_API_KEY }}
+          EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN: ${{ secrets.EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN }}
+          EXPO_PUBLIC_FIREBASE_PROJECT_ID: ${{ secrets.EXPO_PUBLIC_FIREBASE_PROJECT_ID }}
+          EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET: ${{ secrets.EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET }}
+          EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID: ${{ secrets.EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID }}
+          EXPO_PUBLIC_FIREBASE_APP_ID: ${{ secrets.EXPO_PUBLIC_FIREBASE_APP_ID }}
+          EXPO_PUBLIC_API_URL: ${{ secrets.EXPO_PUBLIC_API_URL }}
+        run: |
+          cat > .env << 'ENVEOF'
+          EXPO_PUBLIC_FIREBASE_USE_EMULATOR=false
+          ENVEOF
+          echo "EXPO_PUBLIC_FIREBASE_API_KEY=${EXPO_PUBLIC_FIREBASE_API_KEY}" >> .env
+          echo "EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN=${EXPO_PUBLIC_FIREBASE_AUTH_DOMAIN}" >> .env
+          echo "EXPO_PUBLIC_FIREBASE_PROJECT_ID=${EXPO_PUBLIC_FIREBASE_PROJECT_ID}" >> .env
+          echo "EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET=${EXPO_PUBLIC_FIREBASE_STORAGE_BUCKET}" >> .env
+          echo "EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID=${EXPO_PUBLIC_FIREBASE_MESSAGING_SENDER_ID}" >> .env
+          echo "EXPO_PUBLIC_FIREBASE_APP_ID=${EXPO_PUBLIC_FIREBASE_APP_ID}" >> .env
+          echo "EXPO_PUBLIC_API_URL=${EXPO_PUBLIC_API_URL}" >> .env
+
+      - name: Inject native Firebase config (Android)
+        if: env.GOOGLE_SERVICES_JSON != ''
+        working-directory: apps/mobile
+        env:
+          GOOGLE_SERVICES_JSON: ${{ secrets.GOOGLE_SERVICES_JSON }}
+        run: echo "${GOOGLE_SERVICES_JSON}" | base64 -d > google-services.json
+
+      - name: Inject native Firebase config (iOS)
+        if: env.GOOGLE_SERVICE_INFO_PLIST != ''
+        working-directory: apps/mobile
+        env:
+          GOOGLE_SERVICE_INFO_PLIST: ${{ secrets.GOOGLE_SERVICE_INFO_PLIST }}
+        run: echo "${GOOGLE_SERVICE_INFO_PLIST}" | base64 -d > GoogleService-Info.plist

.github/workflows/sonarcloud.yml

@@ -11,25 +11,74 @@ jobs:
   sonarcloud:
     name: SonarCloud
     runs-on: ubuntu-latest
+    timeout-minutes: 20
     permissions:
       contents: read
-      pull-requests: read
+      pull-requests: write
     env:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+      EXPO_PUBLIC_FIREBASE_USE_EMULATOR: "true"
+      EXPO_PUBLIC_FIREBASE_PROJECT_ID: broodly-dev
     steps:
       - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
         with:
           fetch-depth: 0
 
+      - uses: pnpm/action-setup@f40ffcd9367d9f12939873eb1018b921a783ffaa # v4
+
+      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
+        with:
+          node-version: 20
+          cache: pnpm
+
+      - run: pnpm install --frozen-lockfile
+
+      - name: Generate TypeScript coverage
+        # Coverage (lcov + text-summary) is configured in apps/mobile/jest.config.js.
+        # Passing CLI flags here forwards a literal `--` through nested pnpm, making
+        # jest treat the flags as test-path patterns (0 matches → exit 1).
+        run: pnpm run test
+        continue-on-error: false
+
+      - name: Verify coverage file exists
+        run: |
+          if [ -f "apps/mobile/coverage/lcov.info" ]; then
+            echo "✓ Coverage file found"
+            head -5 apps/mobile/coverage/lcov.info
+          else
+            echo "✗ Coverage file NOT found at apps/mobile/coverage/lcov.info"
+            ls -la apps/mobile/coverage/ || echo "Coverage directory does not exist"
+            exit 1
+          fi
+
+      - name: Normalize lcov paths for monorepo
+        run: |
+          # jest runs with rootDir apps/mobile and emits SF: paths relative to it
+          # (e.g. SF:app/..., SF:src/...). SonarCloud scans from the repo root, so
+          # those paths must be prefixed to repo-root-relative form or coverage
+          # fails to map to any source file (reported as 0% coverage on new code).
+          # Only rewrite relative paths; leave any absolute SF: paths untouched.
+          sed -i 's|^SF:\([^/]\)|SF:apps/mobile/\1|' apps/mobile/coverage/lcov.info
+          echo "Normalized SF: paths (sample):"
+          grep -m 3 "^SF:" apps/mobile/coverage/lcov.info
+
       - uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5
         with:
           go-version-file: apps/api/go.mod
           cache-dependency-path: apps/api/go.sum
 
-      - name: Generate Go coverage for SonarCloud
+      - name: Generate Go coverage
         working-directory: apps/api
-        run: go test -coverprofile=coverage.out ./...
+        run: go test -short -race -coverprofile=coverage.out -timeout=5m ./...
+
+      - uses: actions/setup-java@cf277c60eb25467037889841efdb72551f06f6c3 # v4.9.1
+        with:
+          java-version: 21
+          distribution: temurin
 
       - name: SonarCloud Scan
         if: ${{ env.SONAR_TOKEN != '' }}
         uses: SonarSource/sonarqube-scan-action@fd88b7d7ccbaefd23d8f36f73b59db7a3d246602 # v6
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

_bmad-output/implementation-artifacts/sprint-status.yaml

@@ -93,26 +93,26 @@ development_status:
   9-5-skill-mismatch-detection: review
   epic-9-retrospective: optional
 
-  epic-10: backlog
-  10-1-happy-context-homepage: ready-for-dev
-  10-2-weekly-action-queue: ready-for-dev
-  10-3-task-resolution-actions: ready-for-dev
-  10-4-seasonal-planning-calendar: ready-for-dev
-  10-5-dynamic-priority-updates: ready-for-dev
+  epic-10: done
+  10-1-happy-context-homepage: review
+  10-2-weekly-action-queue: review
+  10-3-task-resolution-actions: review
+  10-4-seasonal-planning-calendar: review
+  10-5-dynamic-priority-updates: review
   epic-10-retrospective: optional
 
-  epic-11: backlog
-  11-1-signed-url-media-upload: ready-for-dev
-  11-2-stt-transcription-worker: ready-for-dev
-  11-3-vision-ai-analysis-worker: ready-for-dev
-  11-4-acoustic-analysis-worker: ready-for-dev
-  11-5-embedding-generation-pipeline: ready-for-dev
+  epic-11: done
+  11-1-signed-url-media-upload: review
+  11-2-stt-transcription-worker: review
+  11-3-vision-ai-analysis-worker: review
+  11-4-acoustic-analysis-worker: review
+  11-5-embedding-generation-pipeline: review
   epic-11-retrospective: optional
 
-  epic-12: backlog
-  12-1-notification-dispatch-service: ready-for-dev
-  12-2-notification-center-ui: ready-for-dev
-  12-3-notification-sensitivity-config: ready-for-dev
-  12-4-alert-escalation-engine: ready-for-dev
-  12-5-feedback-prompts: ready-for-dev
+  epic-12: done
+  12-1-notification-dispatch-service: review
+  12-2-notification-center-ui: review
+  12-3-notification-sensitivity-config: review
+  12-4-alert-escalation-engine: review
+  12-5-feedback-prompts: review
   epic-12-retrospective: optional