Skip to content

feat: implement issue #348 — SonarCloud: S7635 secrets-inherit caller stubs #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
don-petry wants to merge 1 commit into from
Closed

feat: implement issue #348 — SonarCloud: S7635 secrets-inherit caller stubs #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/dependabot-automerge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,20 @@
# App token dance live in the reusable workflow above.
# • You MAY change: nothing in this file in normal use. Adopt verbatim.
# • You MUST NOT change: trigger event (must be `pull_request_target`),
# the `uses:` line, `secrets: inherit`, or the job-level `permissions:`
# block — reusable workflows can be granted no more permissions than the
# calling job has, so removing the stanza breaks the reusable's gh API
# calls.
# the `uses:` line, or the job-level `permissions:` block — reusable
# workflows can be granted no more permissions than the calling job has,
# so removing the stanza breaks the reusable's gh API calls.
# • The `secrets:` block passes only the secrets the reusable declares in
# its `workflow_call.secrets` (APP_ID, APP_PRIVATE_KEY). Keep it in sync
# with that declaration — do not revert to `secrets: inherit` (over-shares
# every org/repo secret; see githubactions:S7635).
# • If you need different behaviour, open a PR against the reusable in the
# central repo.
# ─────────────────────────────────────────────────────────────────────────────
#
# Dependabot auto-merge — thin caller for the org-level reusable.
# To adopt: copy this file to .github/workflows/dependabot-automerge.yml in your repo.
# Required org/repo secrets (inherited):
# Required org/repo secrets (passed explicitly below):
# APP_ID — GitHub App ID with contents:write and pull-requests:write
# APP_PRIVATE_KEY — GitHub App private key
name: Dependabot auto-merge
Expand All @@ -36,4 +39,6 @@ jobs:
contents: read
pull-requests: read
uses: petry-projects/.github/.github/workflows/dependabot-automerge-reusable.yml@dependabot-automerge/ring1 # NOSONAR(githubactions:S7637) first-party channel ref
secrets: inherit
secrets:
APP_ID: ${{ secrets.APP_ID }}
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
13 changes: 11 additions & 2 deletions .github/workflows/pr-review-mention.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,21 @@
# trigger events or the job-level `permissions:` block — reusable workflows
# can be granted no more permissions than the calling job, so removing the
# stanza breaks the reusable's gh API calls.
# • The `secrets:` block passes only the secrets the reusable declares in
# its `workflow_call.secrets` (GH_PAT_WORKFLOWS, DON_PETRY_BOT_GH_PAT).
# Keep it in sync with that declaration — do not revert to
# `secrets: inherit` (over-shares every org/repo secret; see
# githubactions:S7635).
# • If you need different behaviour, open a PR against the reusable in the
# central repo. A new release is rolled out by moving the channel tag
# centrally — never by editing callers, so no fanout PR is needed.
# ─────────────────────────────────────────────────────────────────────────────
#
# PR Review Mention — thin caller for the org-level reusable.
# To adopt: copy this file to .github/workflows/pr-review-mention.yml in your repo.
# Requires: GH_PAT_WORKFLOWS org secret (already present in petry-projects org).
# Requires (org secrets, already present in petry-projects org):
# GH_PAT_WORKFLOWS — classic PAT (repo scope) for API calls and dispatch
# DON_PETRY_BOT_GH_PAT — classic PAT owned by donpetry-bot for posting comments
name: PR Review — Mention Trigger

on:
Expand All @@ -38,4 +45,6 @@ jobs:
permissions:
pull-requests: write
uses: petry-projects/.github/.github/workflows/pr-review-mention-reusable.yml@pr-review-mention/ring1 # NOSONAR(githubactions:S7637) first-party channel ref
secrets: inherit
secrets:
GH_PAT_WORKFLOWS: ${{ secrets.GH_PAT_WORKFLOWS }}
DON_PETRY_BOT_GH_PAT: ${{ secrets.DON_PETRY_BOT_GH_PAT }}
Loading