[Fleet Monitor] petry-projects/TalkTerm — .github/workflows/ci.yml #380

Activity

1. don-petry

   added

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   fleet-trackerTracked by the Actions Fleet MonitorTracked by the Actions Fleet Monitor

   health-checkAutomated health check resultAutomated health check result

   on Jul 19, 2026
2. don-petry commented on Jul 19, 2026

   

   don-petry

   on Jul 19, 2026

   ContributorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #380 — [Fleet Monitor] petry-projects/TalkTerm — .github/workflows/ci.yml

   Root-Cause Analysis

   The two "failures" in the monitored window (2/6 = 33.3%) are both action_required runs on the same bot PR branch (dev-lead/issue-372-…). No jobs ever executed — these are redundant/pending runs created when the dev-lead bot pushed several commits to one PR in quick succession. ci.yml is the only workflow in this repo with no top-level concurrency: block, so redundant runs are never serialized or superseded and pile up as action_required, inflating the failure rate. This is the same class of Fleet Monitor degradation already fixed for pr-review.yml (issue #374) by adding a concurrency: block plus a regression-guard test.

   Scope

   Add a top-level concurrency: block to .github/workflows/ci.yml that serializes runs per Git ref — cancelling outdated PR runs while never cancelling main-branch runs — and add a shell regression-guard test mirroring scripts/test-pr-review-workflow.sh.

   Implementation Checklist

   • scripts/test-ci-workflow.sh — new regression-guard test (written first, must fail)
   • .github/workflows/ci.yml — add top-level concurrency: block (group keyed on github.ref, cancel-in-progress only for pull_request)

   Tests to Write

   • scripts/test-ci-workflow.sh asserting: yq present; ci.yml exists; concurrency.group present and keyed on github.ref; cancel-in-progress scoped to pull_request events (main pushes never cancelled)

   Test Command

   bash scripts/test-ci-workflow.sh (plus bash .dev-lead/scripts/dev-lead-lint.sh, shellcheck, and yamllint .github/workflows/ci.yml)
3. don-petry commented on Jul 19, 2026

   

   don-petry

   on Jul 19, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Implementation Complete

   Root Cause

   Both flagged "failures" in the monitored window (2/6 = 33.3%) were action_required runs on the same bot PR branch (dev-lead/issue-372-…) — no jobs ever executed. ci.yml was the only workflow in the repo with no top-level concurrency: block, so redundant runs created by the bot pushing multiple commits to one PR piled up instead of being superseded, inflating the failure rate. Same class of degradation already remediated for pr-review.yml (#374).

   Plan Execution

   • Root-caused the degradation to missing run serialization
   • Wrote failing regression test scripts/test-ci-workflow.sh (TDD red confirmed)
   • Added top-level concurrency: block to ci.yml (test green)
   • Verified full test set, dev-lead-lint, shellcheck, and rubber-duck reviewed the diff

   Test Results

   $ bash scripts/test-ci-workflow.sh
   === test-ci-workflow ===
   PASS: 'yq' is available
   PASS: .github/workflows/ci.yml exists
   PASS: 'concurrency.group' block present in .github/workflows/ci.yml
   PASS: concurrency group keyed on github.ref in .github/workflows/ci.yml
   PASS: 'concurrency.cancel-in-progress' scoped to pull_request events in .github/workflows/ci.yml
   All checks passed.
   
   $ bash .dev-lead/scripts/dev-lead-lint.sh
     [lint] shellcheck on 5 file(s)...
     [lint] validating CODEOWNERS...
   OK: CODEOWNERS
     [lint] all checks passed
   
   $ shellcheck --severity=warning -x scripts/test-ci-workflow.sh
   shellcheck-clean
   
   $ for t in scripts/test-*.sh; do bash $t; done
   OK scripts/test-ci-workflow.sh
   OK scripts/test-copilot-setup-steps-workflow.sh
   OK scripts/test-pr-review-workflow.sh
   

   Files Changed

   • .github/workflows/ci.yml: added a top-level concurrency: block — group: ci-${{ github.ref }} with cancel-in-progress: ${{ github.event_name == 'pull_request' }}. Outdated PR runs for a superseded commit are cancelled; main-branch pushes are never cancelled so every merged commit is still verified.
   • scripts/test-ci-workflow.sh (new): regression guard mirroring scripts/test-pr-review-workflow.sh; asserts the concurrency block exists, is keyed on github.ref, and scopes cancel-in-progress to pull_request events.

   Notes

   • Each ref gets an isolated lane: PRs use refs/pull/N/merge, main uses refs/heads/main, so lanes never collide and branch protection still evaluates the required secret-scan check on the latest commit.
   • yamllint is not a CI gate in this repo; the org yamllint config uses line-length: 200 (per .dev-lead/.markdownlint-cli2.jsonc), under which the added lines (≤82 chars) pass. A local run with default (80-char) config flagged only pre-existing long lines.
   • No follow-up issues.
4. don-petry

   added a commit that references this issue on Jul 19, 2026

   feat: implement issue #380 — [Fleet Monitor] petry-projects/TalkTerm …

   ...

   a0036c2
5. don-petry

   closed this as completedin #384on Jul 19, 2026
6. don-petry

   added 3 commits that reference this issue on Aug 31, 2026

   feat: implement issue #380 — [Fleet Monitor] petry-projects/TalkTerm …

   ...

   a741c0e

   feat: implement issue #380 — [Fleet Monitor] petry-projects/TalkTerm …

   ...

   10fc706

   feat: implement issue #380 — [Fleet Monitor] petry-projects/TalkTerm …

   ...

   b45a9f9