Skip to content

Compliance: check-suite-auto-trigger-1236702 #226

Closed
#263
Closed
Compliance: check-suite-auto-trigger-1236702#226
#263
Labels
compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

Description

@don-petry
don-petry
opened on May 26, 2026

Compliance Finding

Category: settings
Severity: error
Check: check-suite-auto-trigger-1236702

Detail

Claude (1236702) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh TalkTerm

Standard Reference

standards/github-settings.md

Remediation

Run scripts/apply-repo-settings.sh TalkTerm with a token that has admin access to the repository (requires a classic PAT with repo scope or equivalent):

GH_TOKEN=<admin-pat> bash scripts/apply-repo-settings.sh TalkTerm

This script applies all standard settings defined in standards/github-settings.md in one pass.
For a dry run to preview changes without applying: DRY_RUN=true GH_TOKEN=<admin-pat> bash scripts/apply-repo-settings.sh TalkTerm

This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry
    added
    compliance-auditAutomated compliance audit finding
    claude
    on May 26, 2026

  2. don-petry commented on May 29, 2026

    @don-petry
    don-petry
    on May 29, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-05-29)

    This finding is still open.

    Detail: Claude (1236702) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh TalkTerm

    Standard: standards/github-settings.md

  3. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-05-30)

    This finding is still open.

    Detail: Claude (1236702) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh TalkTerm

    Standard: standards/github-settings.md

  4. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    @dev-lead

  5. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    @dev-lead

  6. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    @don-petry-dev-lead

  7. don-petry commented on Jun 5, 2026

    @don-petry
    don-petry
    on Jun 5, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-06-05)

    This finding is still open.

    Detail: Claude (1236702) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh TalkTerm

    Standard: standards/github-settings.md

  8. don-petry
    added
    dev-leadFor dev-lead agent pickup
    and removed
    claude
    on Jun 6, 2026

  9. don-petry commented on Jun 6, 2026

    @don-petry
    don-petry
    on Jun 6, 2026
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #226 — Compliance: check-suite-auto-trigger-1236702

    Scope

    Add a weekly schedule trigger to the apply-repo-settings workflow so the Claude (app 1236702) check-suite auto-trigger setting is periodically reapplied and cannot silently drift; also touch scripts/apply-repo-settings.sh so the workflow fires immediately when this branch merges to main via its existing paths filter.

    Implementation Checklist

    • .github/workflows/apply-repo-settings.yml — add schedule: cron trigger and add the workflow file to the paths filter
    • scripts/apply-repo-settings.sh — add inline comment identifying the Claude GitHub app by name (meaningful, triggers the paths-filter on merge)

    Tests to Write

    Exception: pure configuration/workflow change — no observable behavioral change in application code. TDD phase skipped per AGENTS.md exception clause. Verification is via dev-lead-lint.sh (ShellCheck) instead.

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh

  10. don-petry
    added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 8, 2026

  11. 1 remaining item

  12. don-petry commented on Jun 8, 2026

    @don-petry
    don-petry
    on Jun 8, 2026
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Analyzed root cause: apply-repo-settings.yml only triggered on changes to .github/settings.yml or scripts/apply-repo-settings.sh; neither changed recently, so settings drifted
    • Confirmed scripts/apply-repo-settings.sh already correctly disables Claude (app 1236702) auto-trigger via PATCH /repos/{repo}/check-suites/preferences
    • Added .github/workflows/apply-repo-settings.yml to the push.paths filter — this PR's merge to main will itself trigger the workflow and re-apply all settings immediately
    • Added weekly schedule cron (0 6 * * 1) to prevent future compliance drift
    • TDD phase skipped — pure workflow configuration change per AGENTS.md exception for pure config/doc changes

    Test Results

      [lint] shellcheck on 1 file(s)...
  [lint] all checks passed

    Files Changed

    • .github/workflows/apply-repo-settings.yml: added .github/workflows/apply-repo-settings.yml to push.paths filter (triggers on merge of this PR) and added weekly schedule cron trigger to prevent settings drift

    Notes

    The immediate fix (disabling Claude auto-trigger) will happen automatically when this PR merges to main — the path-filter addition ensures the workflow runs on that push. The weekly schedule prevents the same drift from recurring. No other files needed changes; scripts/apply-repo-settings.sh was already correct.

  13. don-petry commented on Jun 12, 2026

    @don-petry
    don-petry
    on Jun 12, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-06-12)

    This finding is still open.

    Detail: Claude (1236702) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh TalkTerm

    Standard: standards/github-settings.md

  14. don-petry commented on Jun 19, 2026

    @don-petry
    don-petry
    on Jun 19, 2026
    ContributorAuthor

    Resolved! This check is now passing as of 2026-06-19. Closing automatically.

  15. don-petry
    closed this as completedon Jun 19, 2026
  16. don-petry
    added 8 commits that reference this issue on Jun 22, 2026

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    5cb2815

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    3190081

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    797bf63

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    01f2dc2

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    b558d47

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    3e4cc5c

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    d3ffc8b

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    eda6c0b
  17. don-petry
    added 3 commits that reference this issue on Aug 31, 2026

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    ebb701d

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    a56a998

    feat: implement issue #226 — Compliance: check-suite-auto-trigger-123…

    59fadb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions