feat: implement issue #1297 — Synced stubs in ring repos carry a header naming v1-stable above a uses: line pinned to their ring — bots flag it and agents edit the stub to match by don-petry · Pull Request #1298 · combsmith/.github

don-petry · 2026-10-11T04:31:19Z

Problem

Synced stubs in ring repos carry a header naming v1-stable above a uses: line pinned to their ring — bots flag it and agents edit the stub to match

From the issue: The sweep re-pins a synced stub's uses: line (and agent_ref) to the target repo's ring, but leaves the stub's header comment naming the template's channel. In a ring-0 or ring-1 repo the two then disagree inside one file.

Risk

Low — 12 file(s) changed; no CI- or runtime-critical paths touched.

Test plan

Tests added/updated: test/scripts/deploy-standard-workflows/stub-header-tier-neutral.bats. Verification: bash scripts/dev-lead-lint.sh (shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.

Rollback

Revert this PR. No non-revertible side effects (no tags, migrations, or external state).

Monitoring

This PR's CI checks (Lint + bats) are the success/regression signal.

Closes #1297

codeant-ai · 2026-10-11T04:34:05Z

CodeAnt Nitpicks

1 code suggestion

1. This only renders templates; the sweep skips existing pin-compliant consumer stubs, leaving their old stable-channel headers and the reported fleet mismatch in place.

Incomplete implementation · test/scripts/deploy-standard-workflows/stub-header-tier-neutral.bats:69-71

codeant-ai · 2026-10-11T04:34:17Z

CodeAnt PR Risk: High Risk

The PR should not merge yet: ring-channel deployments may fail because ring_repin_uses passes the conditional sed options as one quoted script.

Assessed commit: 1eea28d63fff

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e38513943e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

don-petry · 2026-10-11T04:47:56Z

Dev-Lead — review-changes (not-applied)

A commit was pushed, but it did not touch any region the review named — the requested changes were not applied. Per requested item:

test/scripts/deploy-standard-workflows/stub-header-tier-neutral.bats:89 — not applied

donpetry-bot · 2026-10-11T04:51:38Z

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T05:51:38Z.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbe1e72208

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-11T05:14:53Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

donpetry-bot · 2026-10-11T05:16:29Z

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T06:16:28Z.

don-petry · 2026-10-11T05:47:09Z

No description provided.

don-petry · 2026-10-11T05:48:37Z

This is a rate-limit notice from the bot — no code changes are needed. The PR has no actionable findings and all CI checks pass.

don-petry · 2026-10-11T05:48:49Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

## Summary
**Bot:** gemini-code-assist[bot]
**Issues addressed:** 0 (non-actionable notice)
**Notice handled:**
- Rate-limit notice ("reached your daily quota limit"): No code changes needed. This is an operational notice indicating the bot cannot process more requests. Posted informational disposition on the original comment.
**Files changed:** None
**Disposition:** Posted comment-disposition marker on the original bot comment ([IC_kwDORyesfc8AAAABa-nYyA](https://github.com/petry-projects/.github/pull/1298#issuecomment-6105971465)) with `disposition=informational`, as the notice contains no actionable code findings. All CI checks pass and the PR is in good state.

don-petry · 2026-10-11T05:50:10Z

This is a quota-limit notice from the bot — no code changes required. All CI checks pass and no actionable code findings to address.

don-petry · 2026-10-11T05:50:22Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0 (quota-limit notice)
- Quota-limit notice: no actionable code findings — dispositioned as informational
Files changed: none
Skipped (informational): 1
```
The bot's comment is a **quota-limit operational notice**, not a code finding. All CI checks pass with no tier 1 blockers, and there are no actionable code issues to fix. The original comment has been dispositioned as `informational` per the non-actionable notice protocol.

donpetry-bot · 2026-10-11T09:02:52Z

No description provided.

don-petry · 2026-10-11T09:05:02Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

## Summary
**Bot:** chatgpt-codex-connector[bot]
**Issues addressed:** 0 (non-actionable notice)
**Action taken:**
- Codex review summary (no findings): Posted `informational` disposition on [IC_kwDORyesfc8AAAABa-naxA](https://github.com/petry-projects/.github/pull/1298#issuecomment-6105455300) — the review shows only metadata (commit cbe1e72, review completed) with no specific findings or suggestions to address.
**Files changed:** None
**Disposition:** The Codex review comment is a neutral overview containing no actionable code findings. Posted disposition reply with `disposition=informational` marker. All CI checks pass, no Tier 1 blockers exist.

don-petry · 2026-10-11T12:49:35Z

No description provided.

don-petry · 2026-10-17T06:59:42Z

No description provided.

don-petry · 2026-10-17T12:14:18Z

No description provided.

don-petry · 2026-10-17T15:41:19Z

No description provided.

don-petry · 2026-10-17T18:33:42Z

No description provided.

don-petry · 2026-10-17T22:22:10Z

No description provided.

don-petry · 2026-10-18T04:38:38Z

No description provided.

don-petry · 2026-10-18T11:07:14Z

No description provided.

don-petry · 2026-10-18T11:08:53Z

Dev-Lead — waiting on PR blockers (intent: fix-reviews)

PR: #1298
No changes were committed, but the PR still can't be marked done: a reviewer requested changes. The retry cron will re-attempt automatically. Next attempt after: 2026-10-18T11:38:50Z

don-petry · 2026-10-18T12:52:15Z

No description provided.

don-petry · 2026-10-18T15:54:04Z

No description provided.

don-petry · 2026-10-18T15:55:26Z

Dev-Lead — waiting on PR blockers (intent: fix-reviews)

PR: #1298
No changes were committed, but the PR still can't be marked done: a reviewer requested changes. The retry cron will re-attempt automatically. Next attempt after: 2026-10-18T16:25:23Z

don-petry · 2026-10-18T16:13:29Z

No description provided.

don-petry · 2026-10-18T18:42:06Z

No description provided.

don-petry · 2026-10-18T18:43:47Z

Dev-Lead — waiting on PR blockers (intent: fix-reviews)

PR: #1298
No changes were committed, but the PR still can't be marked done: a reviewer requested changes. The retry cron will re-attempt automatically. Next attempt after: 2026-10-18T19:13:44Z

sonarqubecloud · 2026-10-18T19:03:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

don-petry · 2026-10-18T19:06:08Z

No description provided.

don-petry · 2026-10-18T22:28:43Z

No description provided.

don-petry · 2026-10-18T22:30:41Z

Re-read the current body of this CodeRabbit summary. The review-limit block is throttle-only, and there are no Actionable, Outside-diff, Nitpick or Retained-concerns sections. The only finding is in the Merge Risk text: the test fixture that fails to render when its pinned ref includes an inline comment. That was already fixed in 63444b5: stub_pinning in dry-run.bats now passes only the first whitespace-separated token (${1%% *}) to ring_repin_uses. The deploy-standard-workflows bats suite passes with 0 failures. The other 'earlier concerns' are unspecified and were covered by earlier review passes.

don-petry · 2026-10-19T04:42:30Z

No description provided.

don-petry · 2026-10-19T13:19:39Z

No description provided.

don-petry · 2026-10-19T13:21:25Z

Dev-Lead — waiting on PR blockers (intent: fix-reviews)

PR: #1298
No changes were committed, but the PR still can't be marked done: a reviewer requested changes. The retry cron will re-attempt automatically. Next attempt after: 2026-10-19T13:51:21Z

don-petry requested a review from a team as a code owner October 11, 2026 04:31

don-petry added the auto-rebase:ready Opts a non-draft PR into auto-rebase without an approval (auto-rebase ready_label) label Oct 11, 2026