Skip to content

Standard: require feature-ideation / pr-auto-review / initiative-driver in ALL repos #844

Closed
#845
Closed
Standard: require feature-ideation / pr-auto-review / initiative-driver in ALL repos#844
#845
Labels
dev-leadFor dev-lead agent pickup

Description

@don-petry
don-petry
opened on Jul 21, 2026

Promote three currently-optional stubs to required org-wide so the weekly Org Standards Compliance Audit (compliance-audit-and-improvement.yml) detects and drives their deployment fleet-wide via remediation issues (the standards-driven mechanism), instead of ad-hoc hand-runs of deploy-standard-workflows.sh.

All three are already deployable shims (via #836/#837): feature-ideation.yml, pr-auto-review.yml, initiative-driver.yml.

Current state (from a dry-run sweep, 2026-07-21)

  • feature-ideation — currently BMAD-conditional (required only where ECOSYSTEMS includes bmad-method). Already present on most repos; gaps: repo-template, broodminder-export (and markets is a body-preserving re-pin).
  • pr-auto-review — optional (pin-checked if present). Gaps: repo-template, broodminder-export (incubator done via feat: add dependabot-rebase workflow standard #52).
  • initiative-driver — optional; on NO repo yet → all 9 consumer repos are gaps.

Scope (standards change)

  1. scripts/compliance-audit.sh
    • Add pr-auto-review.yml and initiative-driver.yml to REQUIRED_WORKFLOWS (currently line ~45).
    • Promote feature-ideation.yml to universal: remove the bmad-method-conditional block (check_required_workflows, ~line 216) and add feature-ideation.yml to REQUIRED_WORKFLOWS.
  2. ⚠️ feature-ideation project_context invariant (the real design decision — do NOT skip): the seed template ships a TODO: placeholder project_context. Making the file merely present satisfy the standard would ship weekly ideation running on "TODO" to every newly-required repo. The audit must treat a still-placeholder project_context as non-compliant — add a finding (e.g. feature-ideation-placeholder-context) when the stub's project_context still matches the template's TODO:/Example: sentinel. Presence alone is necessary but not sufficient. (Severity: recommend error on presence-missing, warning on placeholder-still-present — dev-lead's call, justify it.)
  3. standards/ci-standards.md
    • Update the Required Workflows section (~line 360) to list all three as required org-wide.
    • Update the templates table (~line 308) — change feature-ideation from "BMAD Method ideation pipeline (BMAD-enabled repos only)" to required org-wide; add rows for pr-auto-review / initiative-driver.
    • Note the project_context non-placeholder requirement for feature-ideation.
  4. Tests — update test/scripts/compliance-audit/** (bats) for the expanded REQUIRED_WORKFLOWS, the removal of the BMAD-conditional, and the new placeholder-context finding. Keep the suite green.

Acceptance criteria

  • Audit run flags any repo missing feature-ideation.yml, pr-auto-review.yml, or initiative-driver.yml (error), and any repo whose feature-ideation project_context is still the template placeholder (warning/error).
  • standards/ci-standards.md documents all three as required org-wide + the non-placeholder project_context rule.
  • compliance-audit bats suite green.
  • No change to the reusables or deploy-standard-workflows.sh behavior (this issue is standard-definition only; the deploy mechanism from Make initiative-driver / pr-auto-review / feature-ideation standard deployable shims (+ canonical-PAT migration) #836 already carries the stubs).

Rollout (follows this merge — NOT in scope of this issue)

Once merged, the weekly audit (or a manual workflow_dispatch) files remediation issues for the gaps above (notably initiative-driver ×9). Remediation runs deploy-standard-workflows.sh per repo (seed-if-absent, PR + admin-merge for ruleset-protected repos). Each feature-ideation seed then needs a real per-repo project_context (the placeholder finding tracks this) — preserved thereafter by #836's no-clobber invariant.

Activity

  1. don-petry
    added
    dev-leadFor dev-lead agent pickup
    on Jul 21, 2026

  2. don-petry commented on Jul 21, 2026

    @don-petry
    don-petry
    on Jul 21, 2026
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #844 — Standard: require feature-ideation / pr-auto-review / initiative-driver in ALL repos

    Scope

    Promote feature-ideation.yml, pr-auto-review.yml, and initiative-driver.yml to required org-wide in the compliance audit + standards docs, and flag a still-placeholder feature-ideation project_context as non-compliant.

    Implementation Checklist

    • scripts/compliance-audit.sh: add pr-auto-review.yml and initiative-driver.yml to REQUIRED_WORKFLOWS (~line 45)
    • scripts/compliance-audit.sh: promote feature-ideation.yml to universal — add to REQUIRED_WORKFLOWS, remove the bmad-method-conditional block in check_required_workflows (~line 216)
    • scripts/compliance-audit.sh: add pure helper feature_ideation_context_is_placeholder() (matches the seed TODO:/Example: sentinel) and a feature-ideation-placeholder-context finding (severity warning) emitted from check_required_workflows when the stub is present but still on the template context
    • standards/ci-standards.md: Required Workflows section (~360) — list all three as required org-wide; note the non-placeholder project_context rule
    • standards/ci-standards.md: templates table (~308) — feature-ideation → required org-wide; add pr-auto-review / initiative-driver rows

    Tests to Write

    • New bats file test/scripts/compliance-audit/feature-ideation-placeholder-context.bats — asserts the placeholder helper returns 0 on the seed TODO:/Example: context and non-zero on a customised context (and on an absent block)
    • Assert REQUIRED_WORKFLOWS now contains all three workflows and that check_required_workflows no longer carries the bmad-method conditional

    Test Command

    bats --print-output-on-failure test/scripts/compliance-audit/

    Severity justification

    Missing file → error (via REQUIRED_WORKFLOWS, consistent with all required workflows). Present-but-placeholder project_context → warning: the file is present and correctly pinned; it only needs its one required per-repo edit, so it should not block the same as an outright-missing workflow — but it must still surface so ideation never runs weekly on "TODO".

  3. don-petry commented on Jul 21, 2026

    @don-petry
    don-petry
    on Jul 21, 2026
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • scripts/compliance-audit.sh: added pr-auto-review.yml + initiative-driver.yml to REQUIRED_WORKFLOWS
    • scripts/compliance-audit.sh: promoted feature-ideation.yml to universal — added to REQUIRED_WORKFLOWS, removed the bmad-method-conditional block
    • scripts/compliance-audit.sh: added pure helper feature_ideation_context_is_placeholder() + feature-ideation-placeholder-context finding (warning)
    • standards/ci-standards.md: Required Workflows (now 10), templates table, §9/§10 Conditional-Workflows notes, non-placeholder project_context rule
    • New bats suite test/scripts/compliance-audit/feature-ideation-placeholder-context.bats

    Test Results — bats test/scripts/compliance-audit/

    168 passing, 0 failing

New file — feature-ideation-placeholder-context.bats:
1..8
ok 1 the shipped seed template still-placeholder → guard fires on the untouched stub
ok 2 a placeholder project_context (TODO:/Example: sentinel) is flagged
ok 3 a customised project_context is NOT flagged
ok 4 a stub with no project_context block at all is NOT flagged as placeholder
ok 5 feature-ideation.yml is a universal required workflow
ok 6 pr-auto-review.yml is a required workflow
ok 7 initiative-driver.yml is a required workflow
ok 8 check_required_workflows no longer carries the bmad-method conditional

    Lint: .dev-lead/scripts/dev-lead-lint.sh → all checks passed (shellcheck 27 files + CODEOWNERS). markdownlint-cli2 standards/ci-standards.md → 0 issues.

    Files Changed

    • scripts/compliance-audit.sh: expanded REQUIRED_WORKFLOWS; removed BMAD-conditional feature-ideation check; added placeholder-context guard + pure helper.
    • standards/ci-standards.md: documented all three as required org-wide + the non-placeholder project_context rule; updated templates table and Required Workflows list.
    • test/scripts/compliance-audit/feature-ideation-placeholder-context.bats: new — covers the placeholder guard, expanded REQUIRED_WORKFLOWS, and BMAD-conditional removal.

    Notes

    • Severity: missing file → error (via REQUIRED_WORKFLOWS, uniform with all required workflows); present-but-placeholder project_context → warning (file is present and correctly pinned; it only needs its one required per-repo edit, so it should surface without blocking like an outright-missing workflow).
    • §9 anchor preserved: the ### 9. Feature Ideation … — BMAD Method repos heading (and its anchor) is unchanged because 5 inbound links across the repo depend on it; the org-wide promotion is documented via a Status note in the section body and a note under Conditional Workflows instead of a heading rename.
    • bmad-method ecosystem detection is retained for the "Detected ecosystems" log line — it no longer gates any check.
    • No changes to reusables or deploy-standard-workflows.sh (standard-definition only, per scope).
  4. don-petry
    added a commit that references this issue on Jul 21, 2026

    feat: implement issue #844 — Standard: require feature-ideation / pr-…

    c695c53
  5. don-petry
    closed this as completedin #845on Jul 21, 2026
  6. don-petry
    added a commit that references this issue on Jul 21, 2026

    feat: implement issue #847 — Reconcile universal-required standard (#844

    c07c72a
  7. don-petry
    added a commit that references this issue on Aug 7, 2026

    feat: implement issue #844 — Standard: require feature-ideation / pr-…

    00ab7a2
  8. don-petry
    added a commit that references this issue on Aug 31, 2026

    feat: implement issue #844 — Standard: require feature-ideation / pr-…

    68cb689
  9. don-petry
    added a commit that references this issue on Sep 7, 2026

    feat: implement issue #844 — Standard: require feature-ideation / pr-…

    b77b5c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions