Standards sweep compares only the pin for ring-managed stubs — a stub whose body differs from the template is reported compliant while template-drift fails on it (dependabot-rebase.yml) #1285

Activity

1. don-petry

   added

   bugBug reportsBug reports

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Oct 10, 2026
2. don-petry commented on Oct 10, 2026

   

   don-petry

   on Oct 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #1285 — Standards sweep compares only the pin for ring-managed stubs (repo-template full-body compare, option 1)

   Scope

   Make is_already_compliant in scripts/deploy-standard-workflows.sh also require stub_body_matches_template (the template rendered at the repo's tier channel) when the target repo is repo-template, except for BODY_PRESERVING_WORKFLOWS. Every other repo keeps the pin-only rule.

   Implementation Checklist

   • scripts/deploy-standard-workflows.sh: add a FULL_BODY_COMPARE_REPOS=(repo-template) list + is_full_body_compare_repo helper (basename match, like is_engine_host_target)
   • is_already_compliant: for such a repo and a non-body-preserving workflow, require stub_body_matches_template; update the header comment
   • No change to the deploy path: a drifted repo-template stub already takes the verbatim path re-pinned via emit_ref_for, so the tier pin is kept

   Tests to Write

   New test/scripts/deploy-standard-workflows/repo-template-full-body.bats:

   • repo-template: right pin + a stale comment body (dependabot-rebase.yml) → drift, sync PR planned
   • repo-template: the template verbatim → already compliant (no churn)
   • another repo with the same stale body → still already compliant (pin-only rule kept)
   • repo-template feature-ideation.yml with a tuned project_context → not overwritten (compliant, or re-pinned in place with the body kept)
   • repo-template on a non-stable tier (test registry via CANARY_RINGS) → re-synced body keeps the tier pin; second run is a no-op

   Test Command

   bats test/scripts/deploy-standard-workflows/ (plus bash .dev-lead/scripts/dev-lead-lint.sh)
3. don-petry commented on Oct 10, 2026

   

   don-petry

   on Oct 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Progress (in progress — not yet durable)

   Provisional. Nothing is pushed yet; the automation posts the authoritative
   completion record (with PR number + head SHA) after the push. Treat the notes
   below as intent, not delivered results.

   Plan Execution (intended)

   • Option 1 only: is_already_compliant also requires stub_body_matches_template when the repo is in a new FULL_BODY_COMPARE_REPOS=(repo-template) list, skipping BODY_PRESERVING_WORKFLOWS. Other repos keep the pin-only rule.
   • The deploy path is unchanged: a drifted repo-template stub is overwritten from the template and re-pinned to the channel emit_ref_for computes, so its tier pin stays.

   Files touched (this workspace, not yet pushed)

   • scripts/deploy-standard-workflows.sh: FULL_BODY_COMPARE_REPOS + is_full_body_compare_repo; extended the body-compare condition in is_already_compliant.
   • test/scripts/deploy-standard-workflows/repo-template-full-body.bats (new): stale body on repo-template is drift and gets re-synced; template verbatim is compliant; second run is a no-op; ring1 tier pin is kept on re-sync; broodly/markets/incubator stay pin-only; a tuned feature-ideation.yml is never overwritten. Existing test files are unchanged.

   Notes

   • Trailing-newline-only differences are still invisible. fetch_existing decodes through command substitution, which drops trailing newlines, and stub_body_matches_template is trailing-newline-insensitive by design. A repo-template stub that differs from the template only in trailing newlines would still read as compliant to the sweep, while template_stub_drift.sh (byte compare) flags it. Once any other byte differs, the re-sync writes the template byte-for-byte, so this only affects newline-only drift. Closing it would mean changing fetch_existing, which is outside this issue's scope.
   • feature-ideation.yml on repo-template is exempt as required (BODY_PRESERVING_WORKFLOWS). If template_stub_drift.sh byte-compares that file too, the two checks can still disagree about it; that would have to be fixed on the .github-private side.
4. don-petry commented on Oct 10, 2026

   

   don-petry

   on Oct 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Implementation Complete — PR #1290

   The implementation for issue #1285 is durable: commits are pushed and a pull request is open. This record is backed by verifiable artifacts you can confirm in one click.

   • Pull request: feat: implement issue #1285 — Standards sweep compares only the pin for ring-managed stubs — a stub whose body differs from the template is reported compliant while template-drift fails on it (dependabot-rebase.yml) #1290
   • Head commit: 2ae3322fbf11b2878649e857b63c1ce48cb2f862
   • Net change against main: 2 file(s), +240/-3 lines
   • Run: https://github.com/petry-projects/.github/actions/runs/38095604764

   Review happens on the PR. Acceptance criteria and test results are evidenced by the PR's diff and CI checks — not asserted here. If a later stage fails, this claim is retracted in place.
5. don-petry

   closed this as completedin #1290on Oct 11, 2026
6. don-petry

   added a commit that references this issue on Oct 11, 2026

   feat: implement issue #1285 — Standards sweep compares only the pin f…

   ...

   08d8ec8