You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
canary-rollout: decide the triage for a pending pair with an unresolvable source commit in _frontier_state_resilient (#1244 item 14) #1249
In _frontier_state_resilient's data-gap path (run-history fetch failed, so the pending pairs are reconstructed from tags), a pair whose source commit is unresolvable (empty) is classified PRE_EXISTING on main: _reusable_differs returns 0 when the candidate is empty, so classify_failure 0 unknown 0 yields PRE_EXISTING. The pair is still tracked BLOCKED (fail closed).
Raised in the #1243 review (pure-core refactor, closes #1242), where reviewers disagreed on the right triage:
What triage should "pair pending, source tag unresolvable, run history unreadable" carry?
- (indeterminate), recommended. A tag gap says nothing about whether the reusable changed, and an expected data gap should not read as a regression or a pre-existing failure. Needs a check of how sync-issues and promote --allow-pre-existing treat - versus PRE_EXISTING (they currently rank the same for needs-human).
PRE_EXISTING (today). No change.
REGRESSION. Fails closed hardest but escalates an expected data gap to a human.
Acceptance criteria
The chosen triage is implemented in _frontier_state_resilient with a test, in its own PR.
Implemented by #1314 (merged as d972b20): a pending pair whose source commit is unresolvable in a data gap now carries triage - (INDETERMINATE), and the #1243 test that pinned PRE_EXISTING was flipped on purpose. The same rule covers a resolved candidate with no destination commit. Recorded in ADR-0014 (petry-projects/.github-private).
Activity
fix(reviews): spell out the triage row, print triage_label with print…
fix(reviews): a missing destination commit is an uncompared reusable too
fix(canary-rollout): an unresolvable source commit in a data gap is I…
don-petry commentedon Oct 12, 2026
Implemented by #1314 (merged as d972b20): a pending pair whose source commit is unresolvable in a data gap now carries triage
-(INDETERMINATE), and the #1243 test that pinnedPRE_EXISTINGwas flipped on purpose. The same rule covers a resolved candidate with no destination commit. Recorded in ADR-0014 (petry-projects/.github-private).Generated by Claude Code