Skip to content

feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent - #879

Merged
don-petry merged 10 commits into
mainfrom
dev-lead/issue-873-20260621-1257
Jun 21, 2026
Merged

don-petry merged 10 commits into
mainfrom
dev-lead/issue-873-20260621-1257

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #873

Implemented by dev-lead agent. Please review.

…e docs to cover the feature-ideation agent
@don-petry
don-petry requested a review from a team as a code owner June 21, 2026 13:03
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 32 minutes and 9 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fd261f6b-0af2-4c20-befd-cc98b163bc22

📥 Commits

Reviewing files that changed from the base of the PR and between ce51626 and 0ad0f0e.

📒 Files selected for processing (5)
  • AGENTS.md
  • docs/release/runbook.md
  • docs/release/versioning.md
  • scripts/cut-release.sh
  • tests/test_cut_release.bats
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-873-20260621-1257

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the cross-repo agent feature-ideation across documentation, release scripts, and tests. It documents that feature-ideation's reusable workflow resides in petry-projects/.github and updates scripts/cut-release.sh to recognize the agent while restricting it to --dry-run operations for now. The reviewer notes that during a dry run, the script resolves the git ref against the local repository and prints its SHA, which is misleading since the canonical commits live in the external repository. It is recommended to add a warning or clarifying note to inform users that this SHA is only a placeholder.

Comment thread scripts/cut-release.sh
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 21, 2026 13:10
@don-petry
don-petry disabled auto-merge June 21, 2026 13:11
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-21T14:16:37Z.

@don-petry
don-petry disabled auto-merge June 21, 2026 13:17
@don-petry
don-petry enabled auto-merge (squash) June 21, 2026 13:19
@don-petry
don-petry disabled auto-merge June 21, 2026 13:20
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: none
Status: Quality Gate passed — no issues detected
```
The PR is ready to proceed. All automated checks passed with no blockers.

@don-petry
don-petry enabled auto-merge (squash) June 21, 2026 13:20
@don-petry
don-petry disabled auto-merge June 21, 2026 15:02
@don-petry
don-petry enabled auto-merge (squash) June 21, 2026 15:04
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-21T16:05:58Z.

@don-petry
don-petry disabled auto-merge June 21, 2026 15:06
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
- Quality Gate passed with no issues identified
Files changed: None required
Skipped: N/A (no issues reported)
```
**Status:** ✅ The pull request has passed all quality checks. The SonarCloud analysis reports zero new issues and zero security hotspots. No bot-reported issues require remediation.
**Note:** The gemini-code-assist[bot] review contains a *suggestion* (not a blocker) to add a clarifying note about the git SHA being a placeholder for external cross-repo references, but this is feedback for future consideration rather than a blocking issue.

@don-petry
don-petry enabled auto-merge (squash) June 21, 2026 15:06

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 1bec026080479669ce2d95d715b482cea9425ed0
Review mode: triage-approved (single reviewer)

Summary

Phase-1 enablement of the cross-repo feature-ideation agent in the release tooling. Adds it to valid_agent in cut-release.sh, refuses live (non-dry-run) cuts behind a TODO(#872) since the cross-repo push target is unresolved, prints a placeholder-SHA warning on dry-run, adds bats coverage, and documents the cross-repo model in versioning.md, runbook.md, and AGENTS.md. +106/-8 across 5 files; no new files.

Linked issue analysis

Closes #873. All six acceptance criteria are met: (1) valid_agent accepts feature-ideation and usage/error strings list it; (2) release_ref/channel_ref are name-agnostic and the dry-run prints intended immutable + channel tag names with no mutation; (3) bats cases added for valid_agent acceptance and release_ref/channel_ref formatting; (4) versioning.md documents the {next,ring0,ring1,stable} channel set and the cross-repo (petry-projects/.github) note; (5) runbook.md extends 'Agents covered' plus cut/promote/rollback examples; (6) shellcheck CI is green. The story explicitly instructed NOT to wire the live cross-repo push — the PR correctly leaves only the dry-run path live and refuses live cuts with a TODO, matching the issue's reserved-for-human-decision constraint.

Findings

No blocking findings. The single unresolved review thread (gemini-code-assist, MEDIUM) flagged that the dry-run SHA is resolved from this repo and is misleading for a cross-repo agent; this was substantively addressed — a ::warning:: placeholder note was added in the dry-run block of cut-release.sh and the author replied on the thread. The thread is unmarked-resolved (bookkeeping only); the concern is fixed in code. No secrets, auth, or migration surface. The script change is conservative: it only widens an allowlist and adds a guard that refuses live cross-repo cuts. Secret-scanning MCP tool unavailable in this run; the gitleaks CI check passed.

CI status

All required checks green (Lint, ShellCheck, bats, unit-tests, CodeQL actions+python, SonarCloud, Secret scan/gitleaks, AgentShield, holdout-guard, test-deletion guard, validate-agent-profiles, gh-aw-compile). Dependency-audit ecosystem jobs and dependabot-automerge SKIPPED (expected). Advisory bots CodeRabbit and Codex were rate-limited; SonarCloud Quality Gate passed with 0 new issues. mergeStateStatus is BLOCKED only because org-leads review is still required (normal human gate).


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry disabled auto-merge June 21, 2026 16:19
@don-petry
don-petry enabled auto-merge (squash) June 21, 2026 16:51
@don-petry
don-petry merged commit 82649a4 into main Jun 21, 2026
33 of 35 checks passed
@don-petry
don-petry deleted the dev-lead/issue-873-20260621-1257 branch June 21, 2026 23:30
don-petry added a commit that referenced this pull request Jul 22, 2026
* fix: add S7635 marker on auto-rebase secrets: inherit (#879)

* fix: add S7635 marker on dependabot-automerge secrets: inherit (#879)
don-petry added a commit that referenced this pull request Aug 2, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 3, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 3, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 7, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 8, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 8, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 8, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
don-petry added a commit that referenced this pull request Aug 8, 2026
…e docs to cover the feature-ideation agent (#879)

* feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

* chore: apply manual instructions [skip ci-relay]

* chore: apply manual instructions [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent

2 participants