Repository navigation
feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent - #879
Conversation
…e docs to cover the feature-ideation agent
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
More reviews will be available in 32 minutes and 9 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces support for the cross-repo agent feature-ideation across documentation, release scripts, and tests. It documents that feature-ideation's reusable workflow resides in petry-projects/.github and updates scripts/cut-release.sh to recognize the agent while restricting it to --dry-run operations for now. The reviewer notes that during a dry run, the script resolves the git ref against the local repository and prints its SHA, which is misleading since the canonical commits live in the external repository. It is recommended to add a warning or clarifying note to inform users that this SHA is only a placeholder.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-21T14:16:37Z. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-21T16:05:58Z. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: 1bec026080479669ce2d95d715b482cea9425ed0
Review mode: triage-approved (single reviewer)
Summary
Phase-1 enablement of the cross-repo feature-ideation agent in the release tooling. Adds it to valid_agent in cut-release.sh, refuses live (non-dry-run) cuts behind a TODO(#872) since the cross-repo push target is unresolved, prints a placeholder-SHA warning on dry-run, adds bats coverage, and documents the cross-repo model in versioning.md, runbook.md, and AGENTS.md. +106/-8 across 5 files; no new files.
Linked issue analysis
Closes #873. All six acceptance criteria are met: (1) valid_agent accepts feature-ideation and usage/error strings list it; (2) release_ref/channel_ref are name-agnostic and the dry-run prints intended immutable + channel tag names with no mutation; (3) bats cases added for valid_agent acceptance and release_ref/channel_ref formatting; (4) versioning.md documents the {next,ring0,ring1,stable} channel set and the cross-repo (petry-projects/.github) note; (5) runbook.md extends 'Agents covered' plus cut/promote/rollback examples; (6) shellcheck CI is green. The story explicitly instructed NOT to wire the live cross-repo push — the PR correctly leaves only the dry-run path live and refuses live cuts with a TODO, matching the issue's reserved-for-human-decision constraint.
Findings
No blocking findings. The single unresolved review thread (gemini-code-assist, MEDIUM) flagged that the dry-run SHA is resolved from this repo and is misleading for a cross-repo agent; this was substantively addressed — a ::warning:: placeholder note was added in the dry-run block of cut-release.sh and the author replied on the thread. The thread is unmarked-resolved (bookkeeping only); the concern is fixed in code. No secrets, auth, or migration surface. The script change is conservative: it only widens an allowlist and adds a guard that refuses live cross-repo cuts. Secret-scanning MCP tool unavailable in this run; the gitleaks CI check passed.
CI status
All required checks green (Lint, ShellCheck, bats, unit-tests, CodeQL actions+python, SonarCloud, Secret scan/gitleaks, AgentShield, holdout-guard, test-deletion guard, validate-agent-profiles, gh-aw-compile). Dependency-audit ecosystem jobs and dependabot-automerge SKIPPED (expected). Advisory bots CodeRabbit and Codex were rate-limited; SonarCloud Quality Gate passed with 0 new issues. mergeStateStatus is BLOCKED only because org-leads review is still required (normal human gate).
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…e docs to cover the feature-ideation agent (#879) * feat: implement issue #873 — [Phase 1] Extend cut-release.sh + release docs to cover the feature-ideation agent * chore: apply manual instructions [skip ci-relay] * chore: apply manual instructions [skip ci-relay] --------- Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Closes #873
Implemented by dev-lead agent. Please review.