Skip to content

fix(dev-lead): multiline INTENT_BODY corrupts $GITHUB_ENV (#559) #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
don-petry merged 1 commit into from
Jun 11, 2026
Merged

fix(dev-lead): multiline INTENT_BODY corrupts $GITHUB_ENV (#559) #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/dev-lead-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,18 @@ jobs:
echo "INTENT_CHECKS=$(echo "$ctx" | jq -c '.checks // []')" >> "$GITHUB_ENV"
echo "INTENT_ISSUE_NUMBER=$(echo "$ctx" | jq -r '.issue_number // ""')" >> "$GITHUB_ENV"
echo "INTENT_ACTOR=$(echo "$ctx" | jq -r '.actor // ""')" >> "$GITHUB_ENV"
echo "INTENT_BODY=$(echo "$ctx" | jq -r '.body // ""')" >> "$GITHUB_ENV"
# INTENT_BODY is free text (review/comment bodies) and is frequently
# multiline — e.g. CodeRabbit reviews. A plain `KEY=value` write spills
# the 2nd+ lines into $GITHUB_ENV as invalid entries and fails the step
# ("Unable to process file command 'env'"). Use the heredoc form with a
# RANDOM delimiter so newlines are preserved and a crafted body cannot
# inject extra env vars by embedding the delimiter (it is unguessable).
body_delim="INTENT_BODY_EOF_$(openssl rand -hex 16)"
{
printf 'INTENT_BODY<<%s\n' "$body_delim"
echo "$ctx" | jq -r '.body // ""'
printf '%s\n' "$body_delim"
} >> "$GITHUB_ENV"

- name: Skip — log reason
if: env.INTENT_TYPE == 'skip'
Expand Down
Loading